Code Monkey home page Code Monkey logo

Comments (6)

ColaMint avatar ColaMint commented on August 19, 2024 4

use HxD to replace these bytes in hendi's client, then you get super tubi!

0x00085C01: 0x90
0x00085C02: 0x90

0x00085C08: 0x90
0x00085C09: 0x90

0x00085C21: 0x90
0x00085C22: 0x90

0x00085C32: 0x90
0x00085C33: 0x90

image

from cosmic.

P0nk avatar P0nk commented on August 19, 2024 1

Can you translate to english please?

from cosmic.

 avatar commented on August 19, 2024

I think he is saying that pet's picking up items interferes with using skills/attacking, ie the player has to wait for the pet to finish looting before they can attack.

from cosmic.

StickStack avatar StickStack commented on August 19, 2024

Locally experimenting with changes to PetLootHandler.java down to Character.pickupItem yielded these observations:

  1. Not registering the pet loot opcode removes the responsiveness issues (even with client sends the op at 10 times in 1.4 seconds)
  2. Turning PetLootHandler into a do nothing handler only minimizes the issue
  3. Hardcoding inventory space check to return false so only mesos are ever picked up improved responsiveness
  4. Refactoring the item pickup code to an async queue design that immediately responds with PacketCreator.enableActions() helped a bit

It looks like various code choices are exacerbating the issue but hard to say how much of this is an inherent issue surfaced from higher drop rates. I could also be looking in the wrong place and the MapItem/Map/Player locking code could be the issue.

Other reference to the same issue mentioned (different source but I don't know the history of these repositories):

from cosmic.

Arnuh avatar Arnuh commented on August 19, 2024

public static Packet updatePlayerStats(List<Pair<Stat, Integer>> stats, boolean enableActions, Character chr) {
When a pet is picking up items, the enableActions bool should be false for all updatePlayerStats sent in drop pickup. It has to be true for player pickup.

Turning PetLootHandler into a do nothing handler only minimizes the issue

This has to be false, or it's not doing enough of "nothing"

from cosmic.

ChisBread avatar ChisBread commented on August 19, 2024

This is a limitation of the client. Keywords: super tubi

from cosmic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.