There is a lot of code duplication across all schemata coming from the common fields.

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Closing here, will handle the remaining bits in <a class="issue-link js-issue-link" da

Dry up Common Fields about segment.io-avro HOT 4 CLOSED

original-brownbear commented on September 4, 2024

Dry up Common Fields

from segment.io-avro.

Comments (4)

acmeguy commented on September 4, 2024 1

great. I think that this is also more flexible and re-usable for anyone wanting to use this lib.

from segment.io-avro.

acmeguy commented on September 4, 2024

I suggest a third option and would like to know what you think about it.

Let's consolidate the sub-type classes like you suggest for Video events and leave the redundancy as it is. (That way there are a lot fever files/sub-classes involved)

from segment.io-avro.

original-brownbear commented on September 4, 2024

@acmeguy

If that's an appropriate level of validation for you still, I like that approach. As far as I can see we have no type collisions between properties of various kind of mobile events and such so that should work out fine.

from segment.io-avro.

original-brownbear commented on September 4, 2024

Closing here, will handle the remaining bits in #5

from segment.io-avro.

Recommend Projects