Corresponding code actions for diagnostics about nil HOT 5 OPEN

UriLiteral

This fix could be implemented together with string rewriting under the name rewrite_string,

• URI -> "-string
• "-string <-> ''-string
• Identifier <-> "-string (Attr position)

from nil.

Note that we can get back diagnostics from Code Actions requests. This would make it easier to implement without duplicate checking codes.

• DuplicatedParam
• MergePlainRecAttrset
• MergeRecAttrset

These should be left as-is and let user check what is happening.

• Unused*

These could occur as false-positives during editing. Delete actions would hurt by accidental application. As a reference, rust-analyzer provides an action for if this is intentional, prefix it with an underscore: `_a`, and no actions to delete the binding. But we currently have no similar notations to suppress the warnings.

from nil.

These should be left as-is and let user check what is happening.

I crossed these out now

Unused*

I think it makes sense for rust to do that due to the impurities, but for nix there shouldn't be a reason to have dead code
I also think that code actions should be less conservative than diagnostics by default since you have to manually trigger them, and there are no convert_to_inherit diagnostics for that reason

from nil.

@oxalica I'm interested in trying to implement the UrlLiteral code action. Do you have any more guidance than the post above?

Also happy to chat on Matrix, if that's your thing.

from nil.

@asymmetric

@oxalica I'm interested in trying to implement the UrlLiteral code action. Do you have any more guidance than the post above?

You can follow other PRs like #41. For string content, there are some helper functions for unescaping in syntax::semantic.

Also happy to chat on Matrix, if that's your thing.

I attached my Matrix address in my profile page. But I might not be quite responsive recently.

from nil.