`set_fancy` does not work for some arrays with certain `Bigarray.kind` types. about owl HOT 4 OPEN

I was able to implement a temporary workaround to this issue by using element-wise set. Basically:

1. Convert the slice to a list of coordinates of the target array.
2. Use Owl.Dense.Ndarray.Generic.set and List.iter2 to iterate over the list of coordinates and values and set them one at a time

 List.iter2
  (fun coord val ->
	Owl.Dense.Ndarray.Generic.set coord val) coord_list value_list

I would like to add that this issue also affects the transpose function as well. The offending lines are:

Unfortunately, I haven't been able to find a workaround for this

from owl.

UPDATE: So I managed to find a workaround for computing the transpose of any kind using Owl functions. Essentially, this involves converting between .Any and .Generic representations of an array. The functions that seem to not work on .Generic happen to work on .Any arrays. Here is an implementation of transpose that works for any Bigarray kind:

module Ndarray = Owl.Dense.Ndarray.Generic
module Anyarray = Owl.Dense.Ndarray.Any

let transpose ?axis x =
  let shape = Ndarray.shape x in
  let y = Anyarray.init_nd shape @@ fun c -> Ndarray.get x c in
  let y' = Anyarray.transpose ?axis y in
  Ndarray.init_nd (Ndarray.kind x) (Anyarray.shape y') @@ fun c ->
    Anyarray.get y' c

I suppose this workaround can be generalized to any of the Generic functions that are limited to only 4 bigarray kinds?

Cc @jzstark

from owl.

Nice. The main downside is that this won't scale well since it involves copying everything twice, but at least would circumvent the current unnecessary limitation

from owl.

Nice. The main downside is that this won't scale well since it involves copying everything twice, but at least would circumvent the current unnecessary limitation

Perhaps it can be used only for the Bigarray kinds not currently supported by the Generic module, that's if correctness/usability is prioritized over performance.

I am very interested in getting Generic functions to work for any kind. What part of the codebase would I need to extend to support this functionality? Is it doable or too complicated for someone who doesn't have intimate knowledge of the codebase?

from owl.