Code Monkey home page Code Monkey logo

Comments (8)

jcreinhold avatar jcreinhold commented on May 27, 2024

I'm suspecting this issue is related to the location of the flags in the call to gcc/lack of -lgfortran as a lib/the inability to use -l:libopenblas.a instead of -lopenblas. Perhaps we could add an OWL_LDLIBS environment variable which would default to -lopenblas or perhaps -lm -lopenblas?

I can fork this repo and try it out, unless you see something obviously wrong with the previous implementation.

from owl.

jcreinhold avatar jcreinhold commented on May 27, 2024

For completeness, here is my PKG_CONFIG_PATH. Note that OpenBLAS is present.

PKG_CONFIG_PATH=/.../pcre/8.43/.../lib/pkgconfig:/.../libev/.../lib/pkgconfig:/.../OpenBLAS/0.3.20/.../lib/pkgconfig:/.../gmp/6.1.2/.../lib/pkgconfig:/.../libjpeg/.../lib/pkgconfig:/.../libpng/1.6.37/.../lib/pkgconfig:/.../re2/20190601/.../lib/pkgconfig:/.../sqlite/3.36/.../lib/pkgconfig:/.../zlib/1.2.8/.../lib/pkgconfig:/.../readline/8.0/.../lib/pkgconfig:/.../ncurses/6.1/.../lib/pkgconfig

If I run pkg-config in the build environment, I get the following.

+ pkg-config --cflags openblas
-I/.../OpenBLAS/0.3.20/.../include  
+ pkg-config --libs openblas
-L/.../OpenBLAS/0.3.20/.../lib -lopenblas 

So I believe OpenBLAS and pkg-config are interacting appropriately.

from owl.

jcreinhold avatar jcreinhold commented on May 27, 2024

FWIW, I removed OpenBLAS from PKG_CONFIG_PATH to see if it was interfering with the other OWL_CFLAGS; it failed with the same error.

from owl.

jcreinhold avatar jcreinhold commented on May 27, 2024

Probably worthwhile to put an OWL_LDFLAGS too so we don't have to jam everything into something named LDLIBS. Perhaps just have OWL_ versions for CPP_FLAGS, LDFLAGS, LDLIBS which would be placed in the right location.

from owl.

jcreinhold avatar jcreinhold commented on May 27, 2024

Actually, the error might just be coming from this test where OWL_CFLAGS are ignored. Perhaps this should be moved after cflags are set? Presumably we want to run the test with the same parameters that will be used for the build.

from owl.

jcreinhold avatar jcreinhold commented on May 27, 2024

I'm thinking this error might be coming up is because the build script has a set -e in it. I believe C.c_test should just report if the compilation succeeded or failed, not fail (right?). Perhaps the set -e is killing the process.

from owl.

jcreinhold avatar jcreinhold commented on May 27, 2024

Disregard that; it's failing from this test which kills the build.

from owl.

jcreinhold avatar jcreinhold commented on May 27, 2024

This is solved with a patch akin to #636

from owl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.