Code Monkey home page Code Monkey logo

Comments (9)

chrisdotcode avatar chrisdotcode commented on June 8, 2024

Hello there, I've been a huge fan of min since I saw it first on HN. JavaScript-less feature-parity with bootstrap in around a kilobyte sounds like a dream, and I'd like to start helping out :)

On to the link:

After viewing in both firefox and chrome, it doesn't seem the that navbar actually has any styling at all. And neither do the messages. They just appear as plain HTML to me.

And speaking of messages, custom tags like or aren't semantic. Why not

and with custom classes, instead?

And as for a grid system, why not go up to 12, instead of ten? Not only for feature-parity with bootstrap, but 12 divides into 3 rows or 4 rows nicely when needed, as opposed to just 5 or 2, that you would get with 10.

Finally, when you minimize the site, it still spills over the edges (at least it does in the firefox mobile preview), and I think that's because of all of the

 tags used in the documentation.

I'm actually not a designer, but I'll be happy to submit pull requests as needed.

from min.

scottaohara avatar scottaohara commented on June 8, 2024

heya chris,

a lot of the stuff you mentioned has been addressed in the work that's being done on Min. Check out the latest Less & Sass files in the repository.

However, you bring up a topic that I had been meaning to ask myself. While messages aren't part of the main Min framework anymore, I also was wondering what the thought on using <imessage> and <ico> was, since they're not part of the HTML spec.

I've never had a problem rendering them, but it may make sense to convert those over to class names to be used on container elements of any type.

from min.

owenversteeg avatar owenversteeg commented on June 8, 2024

@scottaohara Good point. I removed <message> elements already and I think it'd be a great idea to change <ico> elements to <span class="ico">s. Bootstrap uses <i> but about 65% of people don't think this is semantically correct.

from min.

scottaohara avatar scottaohara commented on June 8, 2024

i'll push an update to change this later today, unless you get to it first

from min.

owenversteeg avatar owenversteeg commented on June 8, 2024

@chrisdotcode That's an old page - I forgot to update the link. The current latest is at http://pasteht.ml/cwQ02. As a matter of fact, 12-column grids have already been committed (issue #16) and will be used in the upcoming Min 2.0 release (as @scottaohara said.) You can also see them on the updated demo page.

Also, I'd love it if you could help out with Min! If you're looking for something to do, I'd say the best thing you could do is to help with #17 - just make comments in the format of the original post. I realize that this is a bit tedious, however, so if you want to help out with something else I think fixing issue #15 is a great start.

from min.

owenversteeg avatar owenversteeg commented on June 8, 2024

I've revised the page even further, adding information about the percent of browsers supported. http://pasteht.ml/21f15

[edit] Latest page is at http://pasteht.ml/50h26

[edit edit] Latest page is at http://pasteht.ml/Rg0B0

from min.

chrisdotcode avatar chrisdotcode commented on June 8, 2024

Sorry about the stagnant reply, I'll check through the issues and see how I can help :)

from min.

owenversteeg avatar owenversteeg commented on June 8, 2024

@chrisdotcode That'd be great, thanks! The only thing (pretty much) standing in the way of Min 2.0 is Bootstrap compatibility. Check out issue #17 and comment in the style of the original comment if you can. If you're better at JS, check out #15.

from min.

owenversteeg avatar owenversteeg commented on June 8, 2024

New site was pushed with Min 2.0. Check it out!

from min.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.