Comments (7)
Overall like the idea of timezone and better i18n support. Comments added inline with your commit.
Perhaps you could put together a pull request for this?
from pikaday.
I'm not super knowledgeable about the internals so it might not be the most elegant but what I can do is when I'm done with our current project release I'll refine that existing fork as best I find and see how it goes. In the meantime if you have any thoughts don't let me get in the way. I'll post here with any updates.
from pikaday.
All good, I'm happy to help with Pikaday internals and such. Probably best to follow the pattern of turning time on/off and do the same for timezone. Should work without having to specify any timezone or i18n configs.
from pikaday.
hmm how would it work without specifying a timezone? For instance, if a
user is at an organization in Eastern time but they are traveling in
Pacific time. When they log in they want to make sure all dates and times
are displayed in Eastern format even though the datetime stamps are in UTC.
On Mon, Jun 22, 2015 at 3:52 PM, Owen Mead-Robins [email protected]
wrote:
All good, I'm happy to help with Pikaday internals and such. Probably best
to follow the pattern of turning time on/off and do the same for timezone.
Should work without having to specify any timezone or i18n configs.—
Reply to this email directly or view it on GitHub
#19 (comment).
@mhkeller
mhkeller.com
from pikaday.
By not specifying timezone, it would be timezone naive. We shouldn't force
a user to specify a timezone if they don't have to deal with timezones.
What if I'm building an app for an organization that never has to deal with
timezones?
On Mon, Jun 22, 2015 at 12:55 PM, Michael Keller [email protected]
wrote:
hmm how would it work without specifying a timezone? For instance, if a
user is at an organization in Eastern time but they are traveling in
Pacific time. When they log in they want to make sure all dates and times
are displayed in Eastern format even though the datetime stamps are in UTC.On Mon, Jun 22, 2015 at 3:52 PM, Owen Mead-Robins <
[email protected]>
wrote:All good, I'm happy to help with Pikaday internals and such. Probably
best
to follow the pattern of turning time on/off and do the same for
timezone.
Should work without having to specify any timezone or i18n configs.—
Reply to this email directly or view it on GitHub
#19 (comment).@mhkeller
mhkeller.com—
Reply to this email directly or view it on GitHub
#19 (comment).
from pikaday.
I see. I thought you meant "It should work" in that it should somehow detect a timezone and "work" in that sense. Yes I agree it should be optional.
from pikaday.
Looks to be solved. Reopen or create a new issue of not solved. Thanks.
from pikaday.
Related Issues (20)
- `minDate` is a day later when showing time HOT 7
- Deal with Timezone offsets nicely (enhancement / wishlist) HOT 2
- Multiple pickdays get the old hour on open HOT 1
- Should include the fix for resetting min and max dates HOT 1
- Custom format? HOT 3
- Set min-max Time HOT 6
- default date HOT 1
- auto close after select min HOT 1
- Correct Time-Format for php/mysql in value HOT 1
- Getting runtime Error: "Pikaday is not defined" after "jspm install" HOT 2
- Could you merge in 1.5.1? HOT 3
- how to disable time collection for fields that are Date only HOT 3
- Set default time? HOT 2
- Add latest commits from original package HOT 4
- Options to keep the picker open HOT 5
- Hour / Minute isn't set from defaultDate
- incrementMinuteBy not working HOT 1
- onSelect not called when choosing already selected value HOT 1
- moment shouldn't be a dependency HOT 1
- Wrong days - today is Thursday, not Friday HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pikaday.