Code Monkey home page Code Monkey logo

Comments (7)

owenmead avatar owenmead commented on August 22, 2024

Overall like the idea of timezone and better i18n support. Comments added inline with your commit.

Perhaps you could put together a pull request for this?

from pikaday.

mhkeller avatar mhkeller commented on August 22, 2024

I'm not super knowledgeable about the internals so it might not be the most elegant but what I can do is when I'm done with our current project release I'll refine that existing fork as best I find and see how it goes. In the meantime if you have any thoughts don't let me get in the way. I'll post here with any updates.

from pikaday.

owenmead avatar owenmead commented on August 22, 2024

All good, I'm happy to help with Pikaday internals and such. Probably best to follow the pattern of turning time on/off and do the same for timezone. Should work without having to specify any timezone or i18n configs.

from pikaday.

mhkeller avatar mhkeller commented on August 22, 2024

hmm how would it work without specifying a timezone? For instance, if a
user is at an organization in Eastern time but they are traveling in
Pacific time. When they log in they want to make sure all dates and times
are displayed in Eastern format even though the datetime stamps are in UTC.

On Mon, Jun 22, 2015 at 3:52 PM, Owen Mead-Robins [email protected]
wrote:

All good, I'm happy to help with Pikaday internals and such. Probably best
to follow the pattern of turning time on/off and do the same for timezone.
Should work without having to specify any timezone or i18n configs.


Reply to this email directly or view it on GitHub
#19 (comment).

@mhkeller
mhkeller.com

from pikaday.

owenmead avatar owenmead commented on August 22, 2024

By not specifying timezone, it would be timezone naive. We shouldn't force
a user to specify a timezone if they don't have to deal with timezones.
What if I'm building an app for an organization that never has to deal with
timezones?

On Mon, Jun 22, 2015 at 12:55 PM, Michael Keller [email protected]
wrote:

hmm how would it work without specifying a timezone? For instance, if a
user is at an organization in Eastern time but they are traveling in
Pacific time. When they log in they want to make sure all dates and times
are displayed in Eastern format even though the datetime stamps are in UTC.

On Mon, Jun 22, 2015 at 3:52 PM, Owen Mead-Robins <
[email protected]>
wrote:

All good, I'm happy to help with Pikaday internals and such. Probably
best
to follow the pattern of turning time on/off and do the same for
timezone.
Should work without having to specify any timezone or i18n configs.


Reply to this email directly or view it on GitHub
#19 (comment).

@mhkeller
mhkeller.com


Reply to this email directly or view it on GitHub
#19 (comment).

from pikaday.

mhkeller avatar mhkeller commented on August 22, 2024

I see. I thought you meant "It should work" in that it should somehow detect a timezone and "work" in that sense. Yes I agree it should be optional.

from pikaday.

owenmead avatar owenmead commented on August 22, 2024

Looks to be solved. Reopen or create a new issue of not solved. Thanks.

from pikaday.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.