Comments (7)
Firstly, awesome time picker @owenmead !
+1 - the time picker seems unusable currently.
On Ubuntu Linux and Firefox, if I right click first to give the time picker select focus, then I can select (left click as normal) but I have to first right click before it will work.
On Windows 7 (Firefox & Chrome) and Ubuntu Chrome, the time picker does not work at all.
Example here in the "due date time" input box:
http://lukemadera-packages.meteor.com/af-pikaday-basic
Any time estimate on a fix as this is obviously a major bug - @dixso may be right it's simply commenting out the preventDefault line?
from pikaday.
+2 the time picker isn't usable without dixso's modification. Commenting line 462 has worked for me without introducing any obvious issues, but I'll second the up vote for a more complete fix if there is one.
from pikaday.
Good catch. Sloppy of me not to manually test it before pushing version out. It was a simple merge with upstream so I thought I was safe.
Will find out why the preventDefault was there in the first place, and try to maintain that idea while getting the time selectors working again.
from pikaday.
Due to Pikaday#249 I didn't simply comment out the line. Instead do not preventDefault when trying to select time.
Will version bump.
from pikaday.
Thanks, @owenmead! The new fix works great.
from pikaday.
Thanks @owenmead !
from pikaday.
@owenmead It looks like dbushell#249 was rolled back because it because it breaks the month and year dropdown.
from pikaday.
Related Issues (20)
- `minDate` is a day later when showing time HOT 7
- Deal with Timezone offsets nicely (enhancement / wishlist) HOT 2
- Multiple pickdays get the old hour on open HOT 1
- Should include the fix for resetting min and max dates HOT 1
- Custom format? HOT 3
- Set min-max Time HOT 6
- default date HOT 1
- auto close after select min HOT 1
- Correct Time-Format for php/mysql in value HOT 1
- Getting runtime Error: "Pikaday is not defined" after "jspm install" HOT 2
- Could you merge in 1.5.1? HOT 3
- how to disable time collection for fields that are Date only HOT 3
- Set default time? HOT 2
- Add latest commits from original package HOT 4
- Options to keep the picker open HOT 5
- Hour / Minute isn't set from defaultDate
- incrementMinuteBy not working HOT 1
- onSelect not called when choosing already selected value HOT 1
- moment shouldn't be a dependency HOT 1
- Wrong days - today is Thursday, not Friday HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pikaday.