Code Monkey home page Code Monkey logo

Comments (7)

lukemadera avatar lukemadera commented on August 22, 2024

Firstly, awesome time picker @owenmead !

+1 - the time picker seems unusable currently.
On Ubuntu Linux and Firefox, if I right click first to give the time picker select focus, then I can select (left click as normal) but I have to first right click before it will work.
On Windows 7 (Firefox & Chrome) and Ubuntu Chrome, the time picker does not work at all.

Example here in the "due date time" input box:
http://lukemadera-packages.meteor.com/af-pikaday-basic

Any time estimate on a fix as this is obviously a major bug - @dixso may be right it's simply commenting out the preventDefault line?

from pikaday.

cmroberts avatar cmroberts commented on August 22, 2024

+2 the time picker isn't usable without dixso's modification. Commenting line 462 has worked for me without introducing any obvious issues, but I'll second the up vote for a more complete fix if there is one.

from pikaday.

owenmead avatar owenmead commented on August 22, 2024

Good catch. Sloppy of me not to manually test it before pushing version out. It was a simple merge with upstream so I thought I was safe.

Will find out why the preventDefault was there in the first place, and try to maintain that idea while getting the time selectors working again.

from pikaday.

owenmead avatar owenmead commented on August 22, 2024

Due to Pikaday#249 I didn't simply comment out the line. Instead do not preventDefault when trying to select time.

Will version bump.

from pikaday.

cmroberts avatar cmroberts commented on August 22, 2024

Thanks, @owenmead! The new fix works great.

from pikaday.

lukemadera avatar lukemadera commented on August 22, 2024

Thanks @owenmead !

from pikaday.

jkleinsc avatar jkleinsc commented on August 22, 2024

@owenmead It looks like dbushell#249 was rolled back because it because it breaks the month and year dropdown.

from pikaday.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.