Code Monkey home page Code Monkey logo

Comments (12)

DonnieBLT avatar DonnieBLT commented on May 20, 2024 1

Good call! Thanks. @JisanAR03 can you make that change please?

from blt-action.

JisanAR03 avatar JisanAR03 commented on May 20, 2024 1

Good call! Thanks. @JisanAR03 can you make that change please?

@DonnieBLT yeah sir sure

from blt-action.

JisanAR03 avatar JisanAR03 commented on May 20, 2024 1

@JisanAR03 For future reference you can close issues from pull requests on merge using keywords: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue

@kingthorin sir , Thanks for the docs sir, I will something about it for sure☺

from blt-action.

JisanAR03 avatar JisanAR03 commented on May 20, 2024 1

@kingthorin , sorry for my misunderstanding, sir😬
@DonnieBLT ok sir sure😊

from blt-action.

JisanAR03 avatar JisanAR03 commented on May 20, 2024 1

For my 2 cents this issue has been addressed, I'm happy to close it if you want. Just let me know @JisanAR03

@kingthorin yes sir sure

from blt-action.

JisanAR03 avatar JisanAR03 commented on May 20, 2024

@DonnieBLT sir , we can close this issue

from blt-action.

kingthorin avatar kingthorin commented on May 20, 2024

@JisanAR03 For future reference you can close issues from pull requests on merge using keywords: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue

from blt-action.

JisanAR03 avatar JisanAR03 commented on May 20, 2024

@DonnieBLT sir , to close an issue automatically, as @kingthorin sir says, I come with a solution.

  • We can do "if (eventType == "pull_request")" in the existing index.js file, and based on the condition, if the user mentions the issue number like "fix_issue_#10," the issue will close automatically when the PR has approval for the merge.

It's just an approach, sir. Any suggestions for me to implement auto-issue close action?

from blt-action.

kingthorin avatar kingthorin commented on May 20, 2024

Oh I was just pointing it out for the next time you worked on an issue so that you didn't have to ask someone to close things.

I didn't mean for it to be something you had to integrate. (If you can and want to then cool, but that wasn't the point 🙂)

from blt-action.

DonnieBLT avatar DonnieBLT commented on May 20, 2024

Also, if you use GitHub to create the branch from the issue, it will automatically link it to the information section on the right.

from blt-action.

kingthorin avatar kingthorin commented on May 20, 2024

No worries. Looking back I wasn't very clear.

from blt-action.

kingthorin avatar kingthorin commented on May 20, 2024

For my 2 cents this issue has been addressed, I'm happy to close it if you want. Just let me know @JisanAR03

from blt-action.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.