Comments (3)
this shouldnt be possible?
var shouldLoad = _modVersionChecker.CheckModVersion(modData) && _modVersionChecker.CheckModGameVersion(modData, latestGameVersion);
method that prints those errors is CheckModGameVersion
, and CheckModVersion
will return false if a mod is disabled
from owml.
No, that method returns true if a mod is disabled. That was changed to fix #369 where it would log errors about versions for disabled mods.
from owml.
Could've fixed both issues by doing this instead
var shouldLoad = modData.Config.Enabled && _modVersionChecker.CheckModVersion(modData) && _modVersionChecker.CheckModGameVersion(modData, latestGameVersion);
Otherwise its only in LoadMod
(line 141) that it decides to ignore disabled mods
from owml.
Related Issues (20)
- ModHelper.Logger.Log() does not give an Obsolete warning
- ModHelper.Events.Event does not trigger reliably HOT 1
- Make Logging Asynchronous
- IndexOutOfRangeException every time I close out of mod settings.
- OWML stops the options menu's tooltips from appearing HOT 1
- Default settings button has wrong text
- "Leave menu" in mod config menu goes back to the main menu, instead of the MODS tab as expected
- Some buttons in mod menus don't make any noise
- Allow a mod settings option to only show up if you have DLC
- [Request] Steam Deck compatibility HOT 5
- [Request] Add explanation for settings in config menu like in base game menus HOT 2
- Issue with enabling mods using manager - game starts in "vanilla mode" HOT 1
- Disabled mod with cyclic dependency breaks load order HOT 1
- Add a way to disable the wrong game version popup
- Attempt to read non existent files from Xbox version HOT 3
- Add popup and options menu Text components to language controller.
- Game freezes for a second when you click on a mod in the config menu, causing this error to show up repeatedly
- silder can't show value in mod setting
- Flatpak: 'Mods folder not found' warning HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from owml.