Code Monkey home page Code Monkey logo

Comments (3)

aulemahal avatar aulemahal commented on August 25, 2024 1

If I may, have this (check_timeindex) been tested with 360_day data ? I think the principal line would fail (it's missing the align_on arg). This could be ambiguous as the "best" align_on value may differ according to the data frequency and what you're trying to do.

Also, I suggest modifying plot_coords to stringify CFtime objects, rather than convert to numpy datetime. To be sure the plotted date is not modified or dropped. (Ex : gridmap with data on the 29 Feb. Rare, but possible with freq='M').
Both types have da.time.dt.strftime available.

from figanos.

Beauprel avatar Beauprel commented on August 25, 2024

CFTime indexes were causing more problems so the util check_timeindex() converts it to a standard calendar. This was implemented in timeseries() but not in gridmap(). Adding it should do the trick.

from figanos.

Beauprel avatar Beauprel commented on August 25, 2024

Thanks @aulemahal, your suggestion looks good!

About support for 360_day data, check_timeindex doesn't exist for the sole purpose of plot_coords; there was an issue with plotting timeseries with a CFtime index. So I'll revisit this in a separate issue.

from figanos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.