[MacOS] Missing tab close button about otter-browser HOT 13 CLOSED

Close button is not shown at all?
They should be hidden only if tabs are too narrow (with exception of active tab).
Shortcuts configuration should be available soon.

BTW, you can also double or middle click to close them.

from otter-browser.

No, actually no - there is no button. The UI under osx is a bit garbled - new-tab button floats around while the window is being resized and there is no button to close tab. I was meaning to post a screenshot but... otter crashes when I try to close my gmail tab (or navigate away from it; I've tried disabling plugins and restart but this doesn't work) with:

QNetworkReplyImplPrivate::error: Internal problem, this method must only be called once.
The program has unexpectedly finished.

from otter-browser.

Uhm, I see.
Assuming that you have whole Qt SDK installed, could you please check if you have similar issues (missing tab close buttons and crashes) with example browser (examples/webkitwidgets/browser/)?
Close buttons are standard part of QTabBar (as long as it is set to allow to close tabs), so they should be visible in both.
And both of them are using QtWebKit, so common crashes usually means upstream issue.
Does new tab button move only horizontally (with kind of margin from edge of the last tab) or its movements are different?
And does it move to right place after finishing resizing?

from otter-browser.

I have a similar glitch related to the "no close button". If i open many tabs and shift them with the arrows, the close buttons are gone. Not all the time the active tab has a close button. This video illustrates this http://www.youtube.com/watch?v=o-z6BmC3vNo

from otter-browser.

@pythoneer, yeah, this seems to be a bug in TabBarWidget::updateTabs() method, I'll investigate it tomorrow.
But it's probably not the same issue, this one is "platform independent" while original one seems to be Mac only.

from otter-browser.

• I've used link - seems ok but the toolbar there looks differently and the close buttons are ok. A few images to compare:

. tabs in tabbar in otter looks a bit like tabs from settings dialog link;

. in example qtbrowser;

. in otter

. in safari 1 and 2

• new-tab-button moves only horizontally, it seems to be aligned to the center of the window (like the tabs, but this looks like behaviour of settings windows not the browser one) and does not snap back to correct location after finishing resizing. Actually in latest sources it's position seems to be fixed (a few dozens px of the left border) and does not move while resizing. ( 1 and 2 )

from otter-browser.

Thanks for extensive report. :-)

Please try this patch:
http://pastebin.kde.org/p555c5219

It may help with tab bar style ate least.

For missing close buttons... It seems that MacOS uses different order and close buttons get replaced by icon widgets, I hate such kind of issues. :-/
To confirm this please try this patch (it disables icon widget on tab handle):
http://pastebin.kde.org/p3390708a

BTW, for me center aligned tabs were always the ugly part of otherwise pretty nice looking Aqua style. ;-)

from otter-browser.

OK, first patch fixed issue with the New Tab button, though IMHO it would be better to have the button stick to the left-most border of the window.

Second patch fixed issue with the missing close buttons.

SOT: Well - those center aligned tabs actually make quite some sense in preferences dialog. But in things like browser they are plain annoying (also: not used actually ;) )

from otter-browser.

I've applied first patch, it will be a bit harder to fix second issue correctly (since it has to be applied only for MacOS platform), but that part should be fixed soon anyway, thanks for testing. :-)

Why edge for New Tab button?

from otter-browser.

Hm, why edge? More predictable position, nicely balanced with trash icon. I'm not a fan a very movable elements of UI thus in old MDI opera I moved minimize/restore/close MDI buttons to fixed location below same buttons for window making it easier to access (hooray muscle memory ;) ).

from otter-browser.

Uhm, maybe it will be possible to move it there manually, when tool bars configuration will be done.

from otter-browser.

Generally I hope that Otter would allow same level of UI customization as old Opera ;)

from otter-browser.

Yeah, it is one of the goals. ;-)

from otter-browser.