Crash when ending conversation about pidgin-otrng HOT 16 CLOSED

Ohh! @peterpalau ... can we pair tomorrow to check this?

from pidgin-otrng.

@claucece of course we can

from pidgin-otrng.

Hi @claucece, I think so, I was unable to replicate the issue after the modification.

from pidgin-otrng.

Hi @claucece, it's uploaded

from pidgin-otrng.

I realize that this happens mainly when you are using the prekey-server-docker-compose, maybe because of the issues with the permissions or something else.

I recently used some accounts from the jabber.otr.im server and this does not happen.

from pidgin-otrng.

This is one of error that appears when Alice request private conversation with Bob:

pidgin: client.c:826: otrng_client_get_client_profile: Assertion `client->client_profile != NULL' failed.
Aborted (core dumped)

from pidgin-otrng.

Hi @claucece, I notice this line: conv->conn as the culprit ;), looks like conn contains an invalid memory address. This is invoked in (libotr-ng/client.c):

expiration_time = get_session_expiry_time_from(conv->conn);

I added a validation in order to avoid this behavior:

`if( conv!=NULL && conv->conn!=NULL ){

    expiration_time = get_session_expiry_time_from(conv->conn);

    if (conv->conn->keys->last_generated < now - expiration_time) {

      otrng_client_expire_session(conv);

    }

}`

Although conv->conn is still producing the segmentation fault.

from pidgin-otrng.

Thanks @MauroVelasco !

What I did to fix it is:

  for (el = client->conversations; el; el = el->next) {
    if (!conv) {
      return;
    }
      conv = el->data;
    expiration_time = get_session_expiry_time_from(conv->conn);
    if (conv->conn->keys->last_generated < now - expiration_time) {
      otrng_client_expire_session(conv);
    }
  }

from pidgin-otrng.

Hi @claucece , this, Did you uploaded, to test it?

from pidgin-otrng.

Hi @claucece, I did the modification in client.c and testing.

from pidgin-otrng.

@MauroVelasco No, I did not upload hahaha.. Did you test it? Did it work?

from pidgin-otrng.

Hi @claucece, yes I did the change as suggested, don't have the issue until now, let you know if the issue comes again.

from pidgin-otrng.

woo!!! awesome! @MauroVelasco .. should we close it?

from pidgin-otrng.

Awesome! Closing it! <3

from pidgin-otrng.

I did not realized that the change is not pushed ahhaha.. want to push @MauroVelasco ?

from pidgin-otrng.

hi @claucece, yeah, sure I'll in minutes

from pidgin-otrng.