Code Monkey home page Code Monkey logo

Comments (2)

otavioschwanck avatar otavioschwanck commented on May 19, 2024 1

Hi!

first of all big thank you because I really love this Plugin, and it is much better than Harpoon imo.

Just a small bug that I have noticed with the following config

return { "otavioschwanck/arrow.nvim", opts = { show_icons = true, leader_key = 'm', } }

If I press 'm' in a buffer I get the menu for the 'per buffer marks' but when I have the following config

return { "otavioschwanck/arrow.nvim", opts = { show_icons = true, leader_key = 'm', buffer_leader_key = 'M', } }

And I press the 'm' key now I get the global menu. I think this behaviour is very confusing and annoyed me quite a bit when I updated the plugin because of course I was using the first version and when pressing my usual hot keys I get the (at first) confusing per buffer marks menu.

But now that I know what it is I think this new menu is a very cool addition

it was a bug (was setting the buffer_leader_key automatically). Fixed it. Thanks for the issue!

from arrow.nvim.

mateusjdev avatar mateusjdev commented on May 19, 2024

The commit c6bbbb5 actualy cause a new problem, in ui.lua file, the vim.keymap.set() expects a value from getState, if the user has not defined a keymap for buffer_leader_key (which happened to me as I updated the plugin and did not add it to opts{}) it will trown a error:

vim.keymap.set("n", config.getState("buffer_leader_key"), function()

E5108: Error executing lua: vim/keymap.lua:0: lhs: expected string, got nil
stack traceback:
        [C]: in function 'error'
        vim/shared.lua: in function 'validate'
        vim/keymap.lua: in function 'set'
        ...sjdev/.local/share/nvim/lazy/arrow.nvim/lua/arrow/ui.lua:448: in function <...sjdev/.local/share/nvim/lazy/arrow.nvim/lua/arrow/ui.lua:415>

from arrow.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.