Code Monkey home page Code Monkey logo

Comments (14)

bhousel avatar bhousel commented on May 18, 2024

I think for these it's common to use the brand name as the common name that people refer to the place.

We should fill in name and brand and brand:wikidata, which is what #38 is about

from name-suggestion-index.

naoliv avatar naoliv commented on May 18, 2024

It's common because people don't understand brand + the editor also suggests to wrongly use brand in name.

from name-suggestion-index.

naoliv avatar naoliv commented on May 18, 2024

People also wrongly use brand in name because of this gravitystorm/openstreetmap-carto#1874 for example
In some place we need to stop suggesting brand names in name (and this should be in the editors).

from name-suggestion-index.

AntMadeira avatar AntMadeira commented on May 18, 2024

This is issue is still ongoing and should be corrected. iD still pops a warning to fill the name of a gas station with the brand.
Please, correct this, because it's filling the database with wrong names.

from name-suggestion-index.

bhousel avatar bhousel commented on May 18, 2024

This is issue is still ongoing and should be corrected. iD still pops a warning to fill the name of a gas station with the brand.
Please, correct this, because it's filling the database with wrong names.

Can you link to a node where iD shows a warning?
AFAIK if the user picks the "Shell" preset when creating a new gas station, it will default it brand=Shell and name=Shell (which is definitely not wrong), and mappers are free to change the name to something else like name=Shell - Morristown, and iD should preserve the name tag and not raise a warning about it.

from name-suggestion-index.

AntMadeira avatar AntMadeira commented on May 18, 2024

Here's one: https://www.openstreetmap.org/node/2849420428

The default behaviour is definitely wrong. brand is different from name and iD should not promote this.
Even if the name can coincide with the brand, many times, the fuel station has a brand and a specific name, and if iD fills the name automatically, it is populating the database with wrong and meaningless data. For example, in Brazil, almost all fuel stations have a name, different from the brand. New mappers are encouraged to apply these warnings without knowing this is not right.

This is issue is still ongoing and should be corrected. iD still pops a warning to fill the name of a gas station with the brand.
Please, correct this, because it's filling the database with wrong names.

Can you link to a node where iD shows a warning? AFAIK if the user picks the "Shell" preset when creating a new gas station, it will default it brand=Shell and name=Shell (which is definitely not wrong), and mappers are free to change the name to something else like name=Shell - Morristown, and iD should preserve the name tag and not raise a warning about it.

from name-suggestion-index.

bhousel avatar bhousel commented on May 18, 2024

This is the warning I see.. It's prompting me to update the brand tags, but I can set the name to whatever I want:

Screen Shot 2021-10-31 at 12 08 30 PM

If I choose to upgrade it, I get this - that's what you want yes?

Screen Shot 2021-10-31 at 12 10 16 PM

from name-suggestion-index.

1ec5 avatar 1ec5 commented on May 18, 2024

Here's one: https://www.openstreetmap.org/node/2849420428

This node was originally tagged name=GALP a long time ago, manually, before the NSI-based validator was ever implemented. Later, it was tagged brand=GALP manually using OsmAnd. Were you expecting iD to automatically remove the name from the node when you recently used iD to add the brand:wikidata and brand:wikipedia tags?

from name-suggestion-index.

AntMadeira avatar AntMadeira commented on May 18, 2024

The problem is when you don't fill the name field. The warning still pops up.
If you don't know the name and the brand is correct, iD should not show the warning and should not fill the name field with the brand.

If I choose to upgrade it, I get this - that's what you want yes?

Screen Shot 2021-10-31 at 12 10 16 PM

from name-suggestion-index.

AntMadeira avatar AntMadeira commented on May 18, 2024

iD should not remove the name, but it also should not pop up a warning if the name field is empty and, worse, fill it with the brand.

Here's one: https://www.openstreetmap.org/node/2849420428

This node was originally tagged name=GALP a long time ago, manually, before the NSI-based validator was ever implemented. Later, it was tagged brand=GALP manually using OsmAnd. Were you expecting iD to automatically remove the name from the node when you recently used iD to add the brand:wikidata and brand:wikipedia tags?

from name-suggestion-index.

AntMadeira avatar AntMadeira commented on May 18, 2024

In short, this suggestion should not be made:
firefox_b8hzXlHobo

from name-suggestion-index.

bhousel avatar bhousel commented on May 18, 2024

@AntMadeira I hear what you're saying, but I'm having a hard time seeing how name=GALP is worse than having no name at all. I really feel like most people would feel oppositely.

You can change the name to whatever you want, but the gas station should have some name right? People who use maps expect the markers to be labeled with something.

from name-suggestion-index.

tas50 avatar tas50 commented on May 18, 2024

I have to agree with @bhousel on this one. OSM is full of gas stations with no names that don't display correctly and it's really problematic. If a gas station has a non brand name that should be set but the brand is better than no name at all.

from name-suggestion-index.

AntMadeira avatar AntMadeira commented on May 18, 2024

Not every element as name, for the most various reasons. Usually, a fuel station has a name, but you may not fill it because you didn't notice it, hadn't time to right it down, etc. If you're "forcing" people to apply a name, that's worse than having no name at all. Apps show fuel stations as POI, even if there's no name present. The brand will show, and the name will also show if it exists, not because iD decided it should exist.

I think the wiki is very helpful on this:
https://wiki.openstreetmap.org/wiki/Names

from name-suggestion-index.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.