Comments (3)
@qgustavor this is fixed in #24 and released in version 1.6.1
from node-webvtt.
Hi @qgustavor, thanks for this.
Originally this project was made to create HLS playlists from webvtt files and as such, isn't a fully fledged parser. However, I'm ready to do the changes needed to support whatever makes sense for its' users!
I'll look into this, you are also more than welcome to open a PR where we can collaborate if you're in a hurry ;)
from node-webvtt.
I made some changes here: qgustavor@ed62d47
Those add an errors
property to the parser result with the errors thrown curing cue parsing process and change the value of valid
to false if some error was thrown. Cues that could be parsed are also returned.
I'm not sure if the way I made those changes are OK for you, so I'm not sending a pull request by now. Maybe the parseCues
function got too messed.
Edit: About the files with cue parsing issues I found that those're converted from .ass files and the conversion code don't handled blank lines well, so I need to fix it before handling the .vtt files. Anyway, even if it don't need it anymore I think supporting relaxed parsing would a good improvement.
from node-webvtt.
Related Issues (20)
- Hours timestamp should support more than 2 digits HOT 2
- [Suggestion] Add an option for parsing without <v> tags? HOT 2
- [Suggestion] TypeScript Conversion / Support HOT 5
- Remove commander dependency
- Spaces being added in meta header
- Automated testing / code coverage HOT 3
- [Bug] Parser parses empty cues HOT 1
- [Feature Suggestion] Ignore extra header lines HOT 4
- [Compiler] Rounding Error for long decimals HOT 3
- Can we convert Array to WebVTT? HOT 1
- VTT Subs go out of sync when translate from EN to ES. HOT 2
- Subtitles can be compiled in non-chronological order HOT 1
- Handle STYLE blocks HOT 8
- Does not compile metadata
- FEATURE: X-TIMESTAMP-MAP/MPEGTS metadata
- Library throws error with malformed webvtt file HOT 6
- my proposals HOT 6
- Add support for meta option in segmenter HOT 1
- Webvtt parser breaking with X-TIMESTAMP-MAP HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-webvtt.