Code Monkey home page Code Monkey logo

Comments (3)

osk avatar osk commented on June 25, 2024 1

@qgustavor this is fixed in #24 and released in version 1.6.1

from node-webvtt.

osk avatar osk commented on June 25, 2024

Hi @qgustavor, thanks for this.

Originally this project was made to create HLS playlists from webvtt files and as such, isn't a fully fledged parser. However, I'm ready to do the changes needed to support whatever makes sense for its' users!

I'll look into this, you are also more than welcome to open a PR where we can collaborate if you're in a hurry ;)

from node-webvtt.

qgustavor avatar qgustavor commented on June 25, 2024

I made some changes here: qgustavor@ed62d47

Those add an errors property to the parser result with the errors thrown curing cue parsing process and change the value of valid to false if some error was thrown. Cues that could be parsed are also returned.

I'm not sure if the way I made those changes are OK for you, so I'm not sending a pull request by now. Maybe the parseCues function got too messed.

Edit: About the files with cue parsing issues I found that those're converted from .ass files and the conversion code don't handled blank lines well, so I need to fix it before handling the .vtt files. Anyway, even if it don't need it anymore I think supporting relaxed parsing would a good improvement.

from node-webvtt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.