Two questions: Swallowing exceptions? Accepting nullable Throwables? about kotlin-logging HOT 5 CLOSED

Regarding the first issue see the discussion here: #22

Regarding the second issue, a pull request is welcome!

from kotlin-logging.

Thanks for the response! I understand this is a question of preference (or context), some people prefer to be fail-safe, while I'd rather fail-fast. The behavior is also different from Slf4j, compare:

log.underlyingLogger.info("Test: {}", "x".toInt())

with

log.info{"Test ${"x".toInt()}"}

The former throws the exception, the latter doesn't. So I think this should at least be mentioned somewhere in the readme or documentation, otherwise it could lead to some real head scratchers.

I created a pull request for the nullable throwables.

from kotlin-logging.

usually, I also prefer fail-fast than fail-safe. However, I think in this case it is better to be consistent with other logging frameworks. the exception you described above in "x".toInt() is not part of the framework but happened before the framework is called.

from kotlin-logging.

version 1.5.4 was released with nullable throwables (#39)

from kotlin-logging.

Ah, yes, you're right, the logging framework doesn't even even see the exception in the first example.

Thank you for the quick release!

from kotlin-logging.