FielTrait::getFilename ignores query parameters about psr7-middlewares HOT 3 CLOSED

Hello. What are your use case?
This method is used in Middleware::readResponse() and Middleware::saveResponse().
In saveResponse the page is saved only if no query parameters are in the url (https://github.com/oscarotero/psr7-middlewares/blob/master/src/Middleware/SaveResponse.php#L31)
ReadResponse does not check whether there's query parameters in the url. These two middlewares are designed to create a basic file based cache, for static pages, so query parameters are not covered.
Maybe this the problem?

from psr7-middlewares.

My use case is filtering a timeline, so I have "tabs" of sorts that display different content. I think indeed it's caching the page when there's no query parameter (view all) but then that cache is reused when there are query parameters.

from psr7-middlewares.

To do that, you need to use Cache, combined with any psr6 compliance library. In the tests I'm using http://www.scrapbook.cash/ that have adapters for many storage systems including filesystem (using flysystem). An example:

// create Flysystem object
$adapter = new \League\Flysystem\Adapter\Local('/path/to/cache', LOCK_EX);
$filesystem = new \League\Flysystem\Filesystem($adapter);

// create Scrapbook cache object
$cache = new \MatthiasMullie\Scrapbook\Adapters\Flysystem($filesystem);

// create a psr6 Pool object from cache engine
$pool = new \MatthiasMullie\Scrapbook\Psr6\Pool($cache);

//middlewares
$dispatcher = $relay->newInstance([
    Middleware::cache($pool)
]);

from psr7-middlewares.