Comments (2)
@oscarbranson Thanks for putting the effort into this project. It looks great. I could potentially help with the comparison to CO2SYS (or one of the other issues on the TODO list). I am a physical oceanographer, and have recently transferred most of my work from Matlab to Python.
from cbsyst.
Thanks @tompc35 - that would be really useful. I've actually made a start on this, but would welcome help. I was thinking of comparing cbsyst to GLODAP/WOA data, after Orr er al (2015).
I'd like the comparison to be self-contained, so any user can run it on their own system - i.e. get the data, run it through CO2SYS.m, and generate a 'comparison report' containing plots comparing cbsyst to CO2SYS.m (e.g. scripts making the GLODAP plots in the readme). This could be wrapped in two scripts, and the workflow could be something like:
- run get_GLODAP_WOA_data.py (this could generate some matlab code as output?)
- user runs data through CO2SYS, saves output in same directory (with comparable constants)
- run plot_CO2SYS_comparison.py
So far, I've written get_GLODAP_WOA_data.py, which scrapes and combines the GLODAPv1/WOA data, and I've run this through CO2SYS.m so have a comparison dataset offline. plot_CO2SYS_comparison.py is where work is needed.
All that said, it might be worth holding off a couple of weeks until #13 and #8 are closed, which will add the final features to to match the full capabilities of CO2SYS.m. So, I think a roadmap to getting this is done is something like:
- Implement separate input/output TPS conditions (#8)
- Implement Revelle factor reporting (#13)
- Write plot_CO2SYS_comparison.py
- If Alternative Constants (#14) are added, modify comparison scripts to allow for this.
I've created a branch to work on this called co2sys_compare. Feel free to contribute! Happy to discuss further on here.
from cbsyst.
Related Issues (20)
- Temperature sensitivity of Ks? HOT 1
- Vectorising HOT 3
- Python 2.7 Compatability HOT 2
- Parameter I/O
- Alternative Constants? HOT 4
- MyAMI Alternative
- Review H Solvers
- MyAMI Inconsistencies
- Negative TA when low pHtot and pCO2 are given HOT 1
- Circular import HOT 5
- Error when using Bsys function
- Boron fractionation factor (alpha_B) ignored when used as input HOT 1
- Separate T/S/P input & output conditions. HOT 3
- Fails under high pH + high TA
- Failure in kgen dependency when temperature/salinity/pressure are not specified HOT 1
- Pressure Correction
- Add nutrient alkalinity HOT 1
- Implement different pH scales
- Revelle Factor Reporting HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cbsyst.