Code Monkey home page Code Monkey logo

Comments (8)

nickjer avatar nickjer commented on August 31, 2024

I already do this in the VFTSim app. So I am fine with it.

from ood-myjobs.

brianmcmichael avatar brianmcmichael commented on August 31, 2024

I'm fine making the change.

from ood-myjobs.

brianmcmichael avatar brianmcmichael commented on August 31, 2024

Although, the schema is already in place and working. It may be better just to add the job_cache column now, but not refactor all of the extra data into it, that way it will be there if we need it it down the road.

from ood-myjobs.

nickjer avatar nickjer commented on August 31, 2024

The nice thing about the store Brian, is that all you need to do is define the variables as Eric has done, and you won't need to modify any of your Rails code. So there should be no refactoring necessary.

from ood-myjobs.

brianmcmichael avatar brianmcmichael commented on August 31, 2024

Modifying code without modifying functionality is the definition of refactoring.

from ood-myjobs.

nickjer avatar nickjer commented on August 31, 2024

I know, but I am saying you won't need to modify your code at all. You would just add:

store :job_attrs, accessors: [ :name, :batch_host, :staged_dir, :script_name ], coder: JSON

with the schema change. That is all you have to do.

from ood-myjobs.

brianmcmichael avatar brianmcmichael commented on August 31, 2024

done cbbfa0a...159c7af

from ood-myjobs.

ericfranz avatar ericfranz commented on August 31, 2024

Oops. Already opened separate issue #65

from ood-myjobs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.