Comments (8)
I already do this in the VFTSim app. So I am fine with it.
from ood-myjobs.
I'm fine making the change.
from ood-myjobs.
Although, the schema is already in place and working. It may be better just to add the job_cache
column now, but not refactor all of the extra data into it, that way it will be there if we need it it down the road.
from ood-myjobs.
The nice thing about the store
Brian, is that all you need to do is define the variables as Eric has done, and you won't need to modify any of your Rails code. So there should be no refactoring necessary.
from ood-myjobs.
Modifying code without modifying functionality is the definition of refactoring.
from ood-myjobs.
I know, but I am saying you won't need to modify your code at all. You would just add:
store :job_attrs, accessors: [ :name, :batch_host, :staged_dir, :script_name ], coder: JSON
with the schema change. That is all you have to do.
from ood-myjobs.
done cbbfa0a...159c7af
from ood-myjobs.
Oops. Already opened separate issue #65
from ood-myjobs.
Related Issues (20)
- SECURITY: Fix paperclip vulnerability.
- Update ood_core gem with bugfixes
- Add arbitrary "starting state" when submitting jobs till actual status is returned from the batch server HOT 4
- Address Gemfile security vulnerability
- Suppress "Unable to access log file" warnings HOT 1
- This is a test issue
- Log job submission arguments
- Script Name, when creating a new job from a template, should not be editable
- Update sprockets to address security vulnerability HOT 2
- Support WHITELIST_PATH HOT 2
- Template notes should be rendered using Markdown HOT 1
- The "Edit files" button should say "View files" if the template is read-only HOT 1
- Add support for localizing the help text of the default job options
- Add Placeholder / Updated Help For Job Array Spec
- Logfiles Reporting Statusable.classes Array is empty
- Default "simple sequential job" is reported to have no executions on job script HOT 2
- Datatables does not handle long job names well HOT 1
- Job Composer layout is cramped on a smaller screen HOT 1
- setup-production script fails if DATABASE_PATH does not exist HOT 2
- disk io error HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ood-myjobs.