Code Monkey home page Code Monkey logo

Comments (6)

ondrejbudai avatar ondrejbudai commented on September 27, 2024 1

Hmm, seems like EL8 might have a tool old skopeo. We might want to make run this test conditionally based on the skopeo's version. FTR, the new local storage thing isn't targeting EL8, this is EL9+ only.

from osbuild.

thozza avatar thozza commented on September 27, 2024

CC @kingsleyzissou

from osbuild.

kingsleyzissou avatar kingsleyzissou commented on September 27, 2024

Hmm, seems like EL8 might have a tool old skopeo. We might want to make run this test conditionally based on the skopeo's version. FTR, the new local storage thing isn't targeting EL8, this is EL9+ only.

I can update the test to do the conditional skip

Edit: digging into this a bit more, it might also be an overlay issue. @achilleas-k and I ran into this a couple of times with the containers-storage stuff. The trace suggests this too: open /containers/storage/storage.lock: read-only file system

from osbuild.

kingsleyzissou avatar kingsleyzissou commented on September 27, 2024

Sorry my edit doesn't make sense. Because it's vfs not overlay. But still, we did have some issues with the destination not being writable.

Okay last edit: It might be because we're bind mounting the host's container store (which is overlay) to the buildroot which has a vfs driver.

from osbuild.

thozza avatar thozza commented on September 27, 2024

I don't think that we need to update the test, we just need to make sure to disable it on c8s. I did that for the 109 version, since I needed to get the CI to pass and assumed that the stage is not really targeting el8.

https://gitlab.com/redhat/centos-stream/rpms/osbuild/-/blob/c8s/tests/unit-tests/run-unit-tests.sh?ref_type=heads#L100-101

from osbuild.

kingsleyzissou avatar kingsleyzissou commented on September 27, 2024

I don't think that we need to update the test, we just need to make sure to disable it on c8s. I did that for the 109 version, since I needed to get the CI to pass and assumed that the stage is not really targeting el8.

https://gitlab.com/redhat/centos-stream/rpms/osbuild/-/blob/c8s/tests/unit-tests/run-unit-tests.sh?ref_type=heads#L100-101

Yeah fair enough, it looks like the driver isn't getting set properly here : https://github.com/kingsleyzissou/osbuild/blob/bf85884e1a850d5c792a0c8b9934762b8a1a8c82/.github/workflows/test.yml#L51-L52

So maybe just disabling it for el8 is the best

from osbuild.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.