Disable access logs for health endpoints by default about x HOT 5 CLOSED

Upon closer investigation, it looks like the health endpoints should be excluded already: https://github.com/ory/hydra/blob/f588ec69d4fa03f602d3cbb20abd4188195a7375/cmd/server/handler.go#L204

I'll investigate a bit deeper.

Looks like you have to explicitly disable it: https://github.com/ory/hydra/blob/f588ec69d4fa03f602d3cbb20abd4188195a7375/driver/config/serve.go#L71

from x.

So it looks like this was my fault and I didn't investigate deeply enough before creating this; it's actually documented in https://www.ory.sh/hydra/docs/reference/configuration/

    access_log:
      ## disable_for_health ##
      #
      # Disable access log for health endpoints.
      #
      # Default value: false
      #
      # Set this value using environment variables on
      # - Linux/macOS:
      #    $ export SERVE_ADMIN_ACCESS_LOG_DISABLE_FOR_HEALTH=<value>
      # - Windows Command Line (CMD):
      #    > set SERVE_ADMIN_ACCESS_LOG_DISABLE_FOR_HEALTH=<value>
      #
      disable_for_health: false

With that in mind, I wonder how feasible it would be to disable this by default. Does anybody truly benefit from having access logs enabled for health endpoints?

from x.

Thank you for the report! Indeed, the default is that all logs are available. That way you can investigate easily wether e.g. health checks pass. This can help when services start up and are not responsive. If you have high traffic websites or production deployments, it usually makes sense to disable them. Given that this option is available and documented (although we could probably document it better), do you feel that this issue can be closed?

from x.

For clarification, changing this to default to true might improve the experience for new users who expect this to be the case, but it will be a breaking change for people who rely on this feature. So we won't be changing the default, but it would make sense to better document it.

from x.

I'm closing this as there are currently no plans to change the default

from x.