Comments (5)
Upon closer investigation, it looks like the health endpoints should be excluded already: https://github.com/ory/hydra/blob/f588ec69d4fa03f602d3cbb20abd4188195a7375/cmd/server/handler.go#L204
I'll investigate a bit deeper.
Looks like you have to explicitly disable it: https://github.com/ory/hydra/blob/f588ec69d4fa03f602d3cbb20abd4188195a7375/driver/config/serve.go#L71
from x.
So it looks like this was my fault and I didn't investigate deeply enough before creating this; it's actually documented in https://www.ory.sh/hydra/docs/reference/configuration/
access_log:
## disable_for_health ##
#
# Disable access log for health endpoints.
#
# Default value: false
#
# Set this value using environment variables on
# - Linux/macOS:
# $ export SERVE_ADMIN_ACCESS_LOG_DISABLE_FOR_HEALTH=<value>
# - Windows Command Line (CMD):
# > set SERVE_ADMIN_ACCESS_LOG_DISABLE_FOR_HEALTH=<value>
#
disable_for_health: false
With that in mind, I wonder how feasible it would be to disable this by default. Does anybody truly benefit from having access logs enabled for health endpoints?
from x.
Thank you for the report! Indeed, the default is that all logs are available. That way you can investigate easily wether e.g. health checks pass. This can help when services start up and are not responsive. If you have high traffic websites or production deployments, it usually makes sense to disable them. Given that this option is available and documented (although we could probably document it better), do you feel that this issue can be closed?
from x.
For clarification, changing this to default to true might improve the experience for new users who expect this to be the case, but it will be a breaking change for people who rely on this feature. So we won't be changing the default, but it would make sense to better document it.
from x.
I'm closing this as there are currently no plans to change the default
from x.
Related Issues (20)
- sqlcon: Add a way to purge test databases individually HOT 3
- CLI docs renderer is escaping HTML chars
- Add previous tracing providers HOT 1
- upstream reference closed: github.com/fsnotify/fsnotify/issues/340 HOT 1
- Refactor health endpoints to be more intuitive HOT 1
- Zipkin server_url parsed as an empty string
- File provider does not use NewKoanfFileSubKey
- Log format for "json" has low precision
- [keysetpagination] Add `X-Total-Count` header HOT 1
- Allow to configure OTEL collector endpoint HOT 4
- Missing configuration for Jaeger HOT 1
- insufficient locking in configx/provider.go
- CORS wildcard does not work below first subdomain HOT 1
- upstream reference closed: github.com/evanphx/json-patch/pull/158
- Broken Dependency Chain HOT 1
- Missing elastic apm config in otelx/config.schema.json HOT 2
- Allow configuration for IPv4 binding HOT 3
- To support generic string in stringslice HOT 1
- Hydra doesn't like Grafana Cloud OTLP endpoint
- Support GRPC for sending OTel traces
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from x.