Code Monkey home page Code Monkey logo

Comments (4)

aeneasr avatar aeneasr commented on May 23, 2024

That time out is there to protect the proxy from request stragglers and intentionally harmful clients. It would make sense though to have this configurable, which is possible!

from oathkeeper.

andre-perry-deidle avatar andre-perry-deidle commented on May 23, 2024

I was mislead by the name graceful and though it was intended to handle only shutdown or restart of the process. I since found the http server settings applied in https://github.com/ory/graceful/blob/master/http_defaults.go#L55

I'm using this as a sidecar and there is an upstream proxy offloading TLS and handling timeouts. Perhaps oathkeeper could do with a similar method to hydra of trusting upstream for TLS via source IP and XFF headers and disabling timeouts.

from oathkeeper.

aeneasr avatar aeneasr commented on May 23, 2024

I think we can keep this issue open, it's possible to configure the settings provided by graceful which would - I guess - make tons of sense in this scenario. The settings have been used for other projects whose APIs accept - at maximum - POST bodies of max 2kb. In the proxy scenario however, it makes much more sense to be able to configure the timeouts in order to support use cases such as yours.

from oathkeeper.

aeneasr avatar aeneasr commented on May 23, 2024

Closed by #132

from oathkeeper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.