Code Monkey home page Code Monkey logo

Comments (3)

Demonsthere avatar Demonsthere commented on June 7, 2024

Hello there,
Namespaces are an array in the format:

namespaces:
  - name: videos
  - name: file:///etc/keto/namespaces.keto.ts

from k8s.

rubenv avatar rubenv commented on June 7, 2024

@Demonsthere That does not work sadly, if I do that, rather than loading the file I end up with a namespace named like that.

With:

 keto:
    config:
      namespaces:
        location: file:///etc/keto/namespaces.keto.ts

I get:

curl localhost:8082/namespaces
{"namespaces":[{"name":"User"},{"name":"Group"}]}

With

 keto:
    config:
      namespaces:
        - name: file:///etc/keto/namespaces.keto.ts

I get:

curl localhost:8082/namespaces
{"namespaces":[{"name":"file:///etc/keto/namespaces.keto.ts"}]}

As you can see here, it can be an array or an object: https://github.com/ory/keto/blob/e7b107cb57ab2f8f3f2800ff06bab198e433c7f4/embedx/config.schema.json#L320-L362

from k8s.

Demonsthere avatar Demonsthere commented on June 7, 2024

Oh i see, the validation is on the chart level when you are applying overrides. 🤔 The warning is a bit misleading, as the value is passed down to the cm and the application

$ kubectl get cm keto-1688548613-migrate -o yaml                                                                                                                                  
apiVersion: v1
data:
  keto.yaml: |
    namespaces:
      location: file:///etc/keto/namespaces.keto.ts
    serve:
      metrics:
        port: 4468
      read:
        port: 4466
      write:
        port: 4467
kind: ConfigMap
metadata:
  annotations:
    helm.sh/hook: pre-install, pre-upgrade
    helm.sh/hook-delete-policy: before-hook-creation
    helm.sh/hook-weight: "0"
  creationTimestamp: "2023-07-05T09:16:54Z"
  labels:
    app.kubernetes.io/instance: keto-1688548613
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: keto
    app.kubernetes.io/version: v0.11.0
    helm.sh/chart: keto-0.33.4
    ory.sh/watcher: keto
  name: keto-1688548613-migrate
  namespace: default
  resourceVersion: "1038"
  uid: 9fd173d4-b2ed-4850-839e-fba9b2e1f8f6

But I don't think we can remove it 😞, as helm does not support values of oneOf type. We would need to add type specific fields and functions to parse it and then merge with the rest of the config, which seems a bit of a overkill in order to remove one warning msg

from k8s.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.