Code Monkey home page Code Monkey logo

Comments (5)

freezing avatar freezing commented on July 17, 2024 2

Thanks a lot for fixing this. It's working well :)

from ngx-infinite-scroll.

orizens avatar orizens commented on July 17, 2024 1

hi @t1
thanks for reporting.
for a bug fix - it seems like the "height" code (as well as other properties on the window) breaks the js flow and returns an error. This eventually breaks the calculations function.
a possible fix - is checking for

elem.hasOwnProperty('offsetHeight')

and then, perhaps use:

window.document.body.offsetHeight

this should be done for all window properties that are retrieved for calculations.

Good Reference

from ngx-infinite-scroll.

t1 avatar t1 commented on July 17, 2024

@orizens: I'm quite new to js, and try to stick to things like Angular ;-) But you seem to know exactly what would have to be done. Do you think you will be able to find the time to do it? And maybe even can say, when this might be?

from ngx-infinite-scroll.

freezing avatar freezing commented on July 17, 2024

Hi, what's the status of this bug?
It's not working on iPhone as well.

This looks like a quickfix according to your answer.
Is the problem that elem[property] doesn't work on safari at all, or only if the elem is window?

It's nicer to have this fixed in the master branch because I believe most of us are using npm to install the dependencies and it gives us the compiled version, which is not very nice to fix.

from ngx-infinite-scroll.

orizens avatar orizens commented on July 17, 2024

hi @freezing
bug is still opened. fix is not that simple but hope i will have time for it soon.

from ngx-infinite-scroll.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.