Comments (5)
Thanks a lot for fixing this. It's working well :)
from ngx-infinite-scroll.
hi @t1
thanks for reporting.
for a bug fix - it seems like the "height" code (as well as other properties on the window) breaks the js flow and returns an error. This eventually breaks the calculations function.
a possible fix - is checking for
elem.hasOwnProperty('offsetHeight')
and then, perhaps use:
window.document.body.offsetHeight
this should be done for all window properties that are retrieved for calculations.
from ngx-infinite-scroll.
@orizens: I'm quite new to js, and try to stick to things like Angular ;-) But you seem to know exactly what would have to be done. Do you think you will be able to find the time to do it? And maybe even can say, when this might be?
from ngx-infinite-scroll.
Hi, what's the status of this bug?
It's not working on iPhone as well.
This looks like a quickfix according to your answer.
Is the problem that elem[property] doesn't work on safari at all, or only if the elem is window?
It's nicer to have this fixed in the master branch because I believe most of us are using npm to install the dependencies and it gives us the compiled version, which is not very nice to fix.
from ngx-infinite-scroll.
hi @freezing
bug is still opened. fix is not that simple but hope i will have time for it soon.
from ngx-infinite-scroll.
Related Issues (20)
- x-ray blocks npm because license info is missing
- Data is only visible after scrolling again on iOS
- Angular 14 HOT 1
- alwaysCallback is not working in version 13.0.0
- Missing target version for angular 6+ HOT 1
- how do you set the [horizontal] value based on the width of the parent?
- Support Angular@15
- Are you still maintaining this library? HOT 2
- Can ngx-infinite-scroll work with mat-select / mat-option HOT 1
- Shipping without @scarf/scarf HOT 1
- Angular v16 support HOT 3
- Facing issue in ngx-infinite-scroll version 16.0.0 HOT 2
- error NG6002: 'InfiniteScrollModule' does not appear to be an NgModule class. HOT 5
- Scroll events not fired when using Chrome devtools device mode
- Adding new standalone APIs HOT 1
- Scroll events not fired with angular 16 HOT 2
- Repeated events onScrollDown HOT 1
- Trigger event of no scrollbar is present HOT 2
- Upgrade to Angular 17 ? HOT 8
- After reloading the data, the scrolling event becomes invalid HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-infinite-scroll.