Code Monkey home page Code Monkey logo

Comments (1)

brycx avatar brycx commented on August 20, 2024

This is happening due to incorrect and excessive usage of the inline attribute. The current test that fails CI is:

#[test]
fn err_on_keyed_switch_on_reset() {
	let secret_key = SecretKey::from_slice(b"Testing").unwrap();
	let data = "what do ya want for nothing?".as_bytes();

	let mut state = init(Some(&secret_key), 64).unwrap();
	state.update(data).unwrap();
	let _ = state.finalize().unwrap();
	assert!(state.reset(None).is_err());

	let mut state_second = init(None, 64).unwrap();
	state_second.update(data).unwrap();
	let _ = state_second.finalize().unwrap();
	assert!(state_second.reset(Some(&secret_key)).is_err());
}

This test is part of blake2b and because the Blake2b state reset() function is marked as #[inline(always)] the compilation exhausts all the VM's memory.

All inline attributes should be removed from public API's and the library in general should only use inline(always) if there is a serious performance advantage.

from orion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.