Code Monkey home page Code Monkey logo

Comments (13)

bmallet avatar bmallet commented on September 27, 2024 1

Ah and by the way, thank you for this nice app which is Organic Maps, this kind of app is a good way for the people to discover OSM.

from organicmaps.

bmallet avatar bmallet commented on September 27, 2024 1

OK but to get useful and right comment in a note it's better if this note is written after have looked the actual map.
Case i gave in example (https://www.openstreetmap.org/note/4283551) : the organic maps contributor says a shop is closed because he has seen it opened on the map but in fact this shop has been closed in OSM on 2023-07-05 (https://www.openstreetmap.org/node/3501719732/history)
Result : a note useless
And in your example "Useful notes can come about different objects, including missing ones", same kind of trouble could occur : the organic maps contributor write a note for a "new" shop he sees but, because his map is 6 months old, this shop already exit, in fact, in the OSM database for 3 months : definitely this is not an "useful" note.
I do think that telling people who want to contribute, even with notes : "sorry, your map is too old (2 months old) ; before posting a note, please upload an actual version" would be a better way.

from organicmaps.

euf avatar euf commented on September 27, 2024 1

Actually I agree with @bmallet.
Since the editor becomes disables when the map is outdated, the same could be done for the notes.

It would be good to prompt users to update when they wish to edit / leave note. Even better would be not just showing an alert, but with giving a direct option to update maps right now.

As for the Place Page indication, I'll keep it in mind for the further PP redesigns. Not sure if it's possible to cramp it in at the moment.

from organicmaps.

kirylkaveryn avatar kirylkaveryn commented on September 27, 2024 1

Do you have any ideas on where to put it?

Maybe we can reuse the edit place button in pp?
With text "Update map to edit place".

image

And in case of Add Place we can show the alert when user try to open the "add place" with buttons: "update map" (that will opens the download screen) and "cancel" the just close an alert.

from organicmaps.

Jean-BaptisteC avatar Jean-BaptisteC commented on September 27, 2024

Normally if maps is too old, its not possible to edit map

from organicmaps.

patepelo avatar patepelo commented on September 27, 2024

related to #6936 and #7930

from organicmaps.

biodranik avatar biodranik commented on September 27, 2024

Map data edits are blocked without updating maps. Posting notes is not blocked (why should it? Useful notes can come about different objects, including missing ones).

from organicmaps.

biodranik avatar biodranik commented on September 27, 2024

Right, this issue should be solved by promoting/forcing users to update maps. It can be done by displaying the "Update Map" button in the Place Page, and by displaying a warning/note when editing a note.

@euf @kirylkaveryn @Jean-BaptisteC is it hard to add an "Update Map" button into the Place Page? Do you have any ideas on where to put it? The first "Download" button is already displayed in PP when an empty map region is selected. Maybe always displaying update there will be annoying enough to promote map update? Then just reusing the same button/code but only use a different translation for it would be sufficient?

from organicmaps.

biodranik avatar biodranik commented on September 27, 2024

This is a cool idea, is it possible to display the download indicator (simplified, just text percents) in the same Edit Place button?

Regarding Add Place, we can offer an action with two items "Update now" and "Update later", WDYT?

from organicmaps.

kirylkaveryn avatar kirylkaveryn commented on September 27, 2024

@biodranik can you please check this out?
https://www.figma.com/design/zxnZsa3SBaSAPWG0BmZ3Xh/OM-UpdateMap?node-id=0-1&t=hzbrTvBTUmRC6Jam-1

from organicmaps.

kirylkaveryn avatar kirylkaveryn commented on September 27, 2024

Regarding Add Place, we can offer an action with two items "Update now" and "Update later", WDYT?

In case of "Update later" the alert will be closed without any actions right?

from organicmaps.

biodranik avatar biodranik commented on September 27, 2024

On second thought, showing an alert on each addition is very annoying. Blocking notes and the addition of new objects may do more harm to OSM data than more help. Imagine someone traveling for a month or more, without a large amount of data to update everything downloaded (especially now, without incremental updates implemented), but with enough data to update only an app. Maybe nobody else will travel in 5 years to the same places where a person tries to add objects on the map while offline.

A better solution to this issue would be to promote more frequent map data updates, so fixing #6936 indirectly should also help with this issue.

@bmallet did you write a message to that person, why he/she did not update the Organic Maps app for years?

from organicmaps.

bmallet avatar bmallet commented on September 27, 2024

i did not write to "LAPR_luis" and looking at his profile (https://www.openstreetmap.org/user/LAPR_luis) it looks like he's not a frequent contributor

from organicmaps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.