Comments (1)
Cheers for taking the time to suggest some improvements :)
#241, #251 #264 - Would it be possible to target the "shortDescription", "description", "productAttributes" with no dependency of clases?
I don't really like that they're dependent on classes either. Do you have suggestions for how else to do it?
Regarding the image zoomer stuff, if SCP doesn't do all this then the built-in image zoomer just breaks. Possibly there's a nicer way to do it though. Certainly working with most other lightboxes is vastly easier than working with Magento's zoomer when it comes to refreshing the images, but the zoomer is what comes by default so that's what SCP targets.
BTW, SCP supports two image updating 'modes', one where it just directly replaces the main product image, and another where it replaces the whole product-img-box block (i.e. including the 'more views' section etc). It's this second one that this showFullImageDiv() function handles, and it's in this case that all the zoomer code is needed. The much simpler updateProductImage() is used if you just want to update the single image.
and in line #217, $$('#product_addtocart_form p.product-image img').each(function(el) {
use just the ".product-image img" without p tag.
Could do, if it helps when themes aren't using paragraph tags here.
from magento-configurable-simple.
Related Issues (20)
- Displaying Retail Price (Crossed off) and Special Price - Not Working
- Magento Configurable Product Tax Sending Paypal Issue
- Simple product price is not updating in cart
- Lightboxpro zoom issue
- An error occurred during upload this extension on magento 1.8.1.0
- Quantity Attribute Swatch Price Help
- image swap not working
- Mulitple JS errors - OptionsPrice undefined - Magento 1.9.3.4 HOT 2
- Associated product description not change
- Uncaught TypeError: Cannot read property '1741' of undefined
- TypeError: element.options[element.selectedIndex] is undefined
- Selected Prices are not Updating on Product Page
- Link between simple and configurable (dad) products in Json of Magento
- Page loading in div after selecting configurable option
- CPU load
- PHP 7.2 Compatability
- Magento 2 Support HOT 2
- Blank Page Configurable Product
- Wrong price update when Add to Cart HOT 1
- min_price wrong on catalog_product_index_price HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento-configurable-simple.