Code Monkey home page Code Monkey logo

Comments (1)

toasty avatar toasty commented on August 19, 2024

Cheers for taking the time to suggest some improvements :)

#241, #251 #264 - Would it be possible to target the "shortDescription", "description", "productAttributes" with no dependency of clases?

I don't really like that they're dependent on classes either. Do you have suggestions for how else to do it?

Regarding the image zoomer stuff, if SCP doesn't do all this then the built-in image zoomer just breaks. Possibly there's a nicer way to do it though. Certainly working with most other lightboxes is vastly easier than working with Magento's zoomer when it comes to refreshing the images, but the zoomer is what comes by default so that's what SCP targets.

BTW, SCP supports two image updating 'modes', one where it just directly replaces the main product image, and another where it replaces the whole product-img-box block (i.e. including the 'more views' section etc). It's this second one that this showFullImageDiv() function handles, and it's in this case that all the zoomer code is needed. The much simpler updateProductImage() is used if you just want to update the single image.

and in line #217, $$('#product_addtocart_form p.product-image img').each(function(el) {
use just the ".product-image img" without p tag.

Could do, if it helps when themes aren't using paragraph tags here.

from magento-configurable-simple.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.