Plug in a real logger. about orchardcore HOT 11 CLOSED

I'm planning to create FileLoggerProvider that we can subclasses and allow us to create a variety of file logger such as TextLoggerProvider, XmlLoggerProvider .. etc

So can can I make a PR , or shall I write a sample code to show you my humble design?

from orchardcore.

/cc @Jetski5822

from orchardcore.

Argh, my comment didn't save.

I think its a good idea to give it a go, have you seen the https://GitHub.com/aspnet/logging work?

I'll comment more tomorrow as on phone at mo.

from orchardcore.

Of course and I did a humble PRs, so shall I make a PR or write a code snippet first

from orchardcore.

Lets take a look at a code snippet :)

from orchardcore.

Sure 😄

from orchardcore.

aspnet/Logging#201

from orchardcore.

So, create a LoggingModule : IModule, add add a Logger based on configuration. Then if we want to log to a file, its just configuration.

Make the default NLog? Or console?

Whatcha think?

from orchardcore.

Of course the configuration is very handy in almost the providers: logging, authentication .. etc. The ConsoleLogger is good as default logging provider, also we may need sort of CompositeProvider to log into different sources at one shoot, let me take the initiative 😄 , I planned to do that from few weeks ago but I stuck every time on launching the url, I appreciate your effort to make the fix, it is time to move into this 👍

from orchardcore.

@Jetski5822 I faced some issues:
1- I got MissingMethodException in GetRefrencingLibraries whenever i'm trying to run unit test
2- Is there a default configuration file that we can put the logger settings
3- If I create a LoggingModule that implement IModule, is the DI of IServiceCollection done out of the box, or shall I do some extra stuff

from orchardcore.

Okay done! To plug in another logger we just need to create a module and implement the ILoggingInitiator interface. This will then get added to the Logger pipeline at the ApplicationServices level.

i.e.

public class LoggingInitiator : ILoggingInitiator {
    public void Initialize(ILoggerFactory loggerFactory) {
        loggerFactory.AddConsole(LogLevel.Debug);
    }
}

For NLog

public class LoggingInitiator : ILoggingInitiator {
    public void Initialize(ILoggerFactory loggerFactory) {
        loggerFactory.AddNLog(LogLevel.Debug);
    }
}

from orchardcore.