Comments (7)
Where exactly do you provide this number as the input?
I suppose it's a culture thing, and the culture of the app is one that uses a different decimal separator.
from orchardcore.
Yes this is because of culture setting. I'm using Swedish regional settings where we have the decimal point as comma (,).
The value comes from the internal representation after adding or moving a task or event. I looked a little bit at the javascript to see if it could be changed to always treat it as int, but didn't find the source. But I think it's correct to use a decimal point as the storage format. The comma is only used for presentation.
from orchardcore.
We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).
This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.
from orchardcore.
Got it, thanks!
from orchardcore.
I encountered the same issue a couple weeks back, but the repro was quite exotic, so I didn't report it. The interesting thing about this feature is that the editor uses a 10 by 10 pixel grid to snap elements into such positions that the coordinates are always divisible by 10, thus they will always be integers.
The only way I could break this and produce the same error is by having the fingerprinting-client-rects-noise
flag in Ungoogled Chromium enabled (chrome://flags/#fingerprinting-client-rects-noise), which does the following:
Scale the output values of Range::getClientRects() and Element::getBoundingClientRect() with a randomly selected factor in the range -0.0003% to 0.0003%, which are recomputed on every document initialization. ungoogled-chromium flag, Bromite feature.
That's one part of the error regarding integer conversion, but culture settings also play a role (decimal point vs. comma).
@microposmp are you using this flag?
from orchardcore.
No, I've not set any flags explicitly. Running the latest version of Edge and can reproduce the issue 100% of the time when moving an element in the workflow editor. I think that the fractional numbers can be caused by my scale settings. Using 250% scale setting in Windows. 100% scale in the browser.
from orchardcore.
I didn't think about Windows scaling, although I would expect it to produce different numbers. The number shown in your screenshot is very similar (in terms of inaccuracy) to those I saw in my testing. Maybe Edge has fingerprinting deception features enabled by default, in which case this is less exotic than I thought. :)
from orchardcore.
Related Issues (20)
- Re-add automatic NPM package updates once we have UI testing HOT 1
- Update Azure Blob Storage to follow MS security best practices HOT 8
- Target attribute on menus breaks HTML validation HOT 3
- Make the first Event added to a workflow the startup task by default HOT 1
- Task-type Workflows Activities an also be set as startup task
- Database breaks when multiple features are enabled in a single recipe HOT 9
- liquid script tag does not render custom attributes HOT 19
- OrchardCore.Twitter breaks workflow editor HOT 7
- Allow users to enter custom list of items for each content item HOT 4
- Migrations can stuck in a failing state after an import enables multiple features HOT 1
- FE theme dlls missing in custom bin folder in release build HOT 3
- Can't deserialize LocalizedString and LocalizedHtmlString out of the box HOT 21
- Trumbowyg editor modals display in light mode while dark mode is active HOT 5
- .net8+orchardcore blazorserver mode render component error HOT 10
- liquid jsonparse is stricter compared to oc 1.7 HOT 2
- Error when disabling Lucine or elastic search feature HOT 7
- Lucene.Net.QueryParsers.Classic.ParseException HOT 2
- Shell blueprint is missing dependencies HOT 3
- Support HTML in Markdown by default HOT 1
- Rebuilding Lucene Index fails HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from orchardcore.