Code Monkey home page Code Monkey logo

Comments (13)

sebastienros avatar sebastienros commented on August 16, 2024 1

@maksim-markin We understand that you created a type name "Global Notification" and this is not related to the notifications module (that was confusing so I prefer the state it).

My understanding of the issue is that the return url is lost when we switch languages, so publishing a new localized version won't go back to the content items page like when create a new content item does.

from orchardcore.

github-actions avatar github-actions commented on August 16, 2024

Thank you for submitting your first issue, awesome! ๐Ÿš€ We're thrilled to receive your input. If you haven't completed the template yet, please take a moment to do so. This ensures that we fully understand your feature request or bug report. A core team member will review your issue and get back to you.

If you like Orchard Core, please star our repo and join our community channels.

from orchardcore.

hishamco avatar hishamco commented on August 16, 2024

@MikeAlhayek is this by design?

from orchardcore.

MikeAlhayek avatar MikeAlhayek commented on August 16, 2024

I am not sure. I did not design the culture feature

from orchardcore.

hishamco avatar hishamco commented on August 16, 2024

I thought it was notification-related. I will have a look then

from orchardcore.

maksim-markin avatar maksim-markin commented on August 16, 2024

This behavior actual with every content type not for only notification

from orchardcore.

hishamco avatar hishamco commented on August 16, 2024

Please another screenshot

from orchardcore.

maksim-markin avatar maksim-markin commented on August 16, 2024
  1. Open Manage Content (type = page)
    pic1

  2. Edit some page (there is a returnUrl param) and change current localization
    pic2

  3. Localized version has been created (there is no returnUrl param)
    pic3

  4. After published, page doesn`t close
    pic4

from orchardcore.

github-actions avatar github-actions commented on August 16, 2024

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

from orchardcore.

sebastienros avatar sebastienros commented on August 16, 2024

I kind of agree with the expectation, that we should return to the previous returnUrl value if there was one.

from orchardcore.

maksim-markin avatar maksim-markin commented on August 16, 2024

@maksim-markin We understand that you created a type name "Global Notification" and this is not related to the notifications module (that was confusing so I prefer the state it).

My understanding of the issue is that the return url is lost when we switch languages, so publishing a new localized version won't go back to the content items page like when create a new content item does.

This behavior actual with every content type not for only notification
See screens above

from orchardcore.

maksim-markin avatar maksim-markin commented on August 16, 2024

Related Pull Request: #16325

from orchardcore.

hishamco avatar hishamco commented on August 16, 2024

I unassigned myself while you started a PR

from orchardcore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.