I'm trying to understand the buffer switch behaviour as the view state restoring is so

Say you have 2 files open: init.lua session </ul

Thanks for debugging this one. Fixed via <a href="https://github.com/orb

Buffer switch behaviour about textadept HOT 7 CLOSED

orbitalquark commented on May 27, 2024

Buffer switch behaviour

from textadept.

Comments (7)

orbitalquark commented on May 27, 2024

Textadept switches to the "wrong" buffer first because after `buffer:close()`, the buffer immediately before it in `_BUFFERS` is shown/switched to. However, https://github.com/orbitalquark/textadept/blob/cfc696571b49fa0728b19a32671cc6f651181611/core/ui.lua#L442 tries to restore the last visible buffer on `buffer:close()`, so that is why you're seeing two separate save events. (The duplicate restore event I'm unsure of.) Do you need `save_view_state()` to be called immediately on the new buffer to populate those fields? Other than the fields existing, nothing meaningful is saved, which is why I don't do it.

from textadept.

rgieseke commented on May 27, 2024

Say you have 2 files open:

init.lua
session

You go to the first opened init.lua, then you open a new buffer and close the new buffer:

What happens is:

Saving view state	session
Switch to init.lua
Restoring	init.lua
Switch to init.lua
Restoring	init.lua

So if you change wrap mode oder margins in the new buffer (like i do in Textredux) the session file passed by while closing inherits the view state from the new buffer.

The problem seems to be that there is no "after_switch" event fired for the passing-by of the last buffer in _BUFFERS.

from textadept.

orbitalquark commented on May 27, 2024

Thanks for the concrete example. I'll take a look at this when I have some time.

from textadept.

rgieseke commented on May 27, 2024

Thanks!

Maybe disconnecting events before the switch to the previous buffer could be a fix.

-- Keeps track of, and switches back to the previous buffer after buffer close.
events.connect(
  events.BUFFER_BEFORE_SWITCH, function() view._prev_buffer = buffer end)
events.connect(events.BUFFER_DELETED, function()
  if _BUFFERS[view._prev_buffer] and buffer ~= view._prev_buffer then
    events.disconnect(events.VIEW_BEFORE_SWITCH, save_view_state)
    events.disconnect(events.BUFFER_BEFORE_SWITCH, save_buffer_state)
    view:goto_buffer(view._prev_buffer)
    events.connect(events.BUFFER_BEFORE_SWITCH, save_view_state)
    events.connect(events.VIEW_BEFORE_SWITCH, save_view_state)
  end
end)

Seems to fix the example scenario above, will check further. Maybe not both need to be disconnected. [Edited to use correct event]

from textadept.

rgieseke commented on May 27, 2024

The above would likely work with save_view_state only.

Thus, the following also seems to do the trick:

-- Keeps track of, and switches back to the previous buffer after buffer close.
events.connect(
  events.BUFFER_BEFORE_SWITCH, function() view._prev_buffer = buffer end)
events.connect(events.BUFFER_DELETED, function()
  if _BUFFERS[view._prev_buffer] and buffer ~= view._prev_buffer then
    restore_view_state()
    view:goto_buffer(view._prev_buffer)
  end
end)

from textadept.

orbitalquark commented on May 27, 2024

Thanks for debugging this one. Fixed via 0ef954c

from textadept.

rgieseke commented on May 27, 2024

Awesome, thank you!
Next time i'll try to submit a reproducible test case, this is nice :-)

from textadept.

Buffer switch behaviour about textadept HOT 7 CLOSED

Comments (7)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent