Custom error message when incorrect-architecture OCI.DLL is in PATH on Windows about odpi HOT 4 CLOSED

Thank you! It works fine. But could you fix following?
Check the length of destination of strcpy and strcat to prevent buffer overrun.
When length > _MAX_DIR, it loops infinitely.
Use snprintf instead of sprintf to prevent buffer overrun.

As for this code I prefer predefined macros as follows to checking sizeof(void*).
But it is just my preference. There is no need to fix it.

#if defined _M_AMD64
    if (ntHeaders.FileHeader.Machine == IMAGE_FILE_MACHINE_AMD64)
        return 1;
#elif defined _M_IX86
    if (ntHeaders.FileHeader.Machine == IMAGE_FILE_MACHINE_I386)
        return 1;
#else
#error unsupported architecture
#endif

from odpi.

Thank you! It satisfies my request.

from odpi.

I just pushed a commit to address this. Please take a look and let me know if that addresses your request. Thanks!

from odpi.

I just pushed changes based on your suggestions. Thanks. Some of those should be "impossible", but the Windows documentation doesn't state it is, so better safe than sorry!

from odpi.