Code Monkey home page Code Monkey logo

Comments (6)

anthony-tuininga avatar anthony-tuininga commented on September 1, 2024

I'll take a look and will implement this suggestion if there aren't any difficulties in doing so!

from odpi.

kubo avatar kubo commented on September 1, 2024

Thank you! I'm looking forward to it.

from odpi.

anthony-tuininga avatar anthony-tuininga commented on September 1, 2024

I created the structure dpiDataTypeInfo as suggested. Thanks! It made sense. The nullOk member is only relevant for queries (not object attributes and collection elements) but the other members all do make sense, and it simplified the code a fair bit, too. Take a look and let me know if that answers your request.

from odpi.

kubo avatar kubo commented on September 1, 2024

Thank you!

When I wrote the dpiDataTypeInfo, I didn't realize that nullOK is unavailable for object attributes and collection elements. Sorry to bother you, but could you remove the nullOk member from the dpiDataTypeInfo and put it back to dpiQueryInfo? I think that it is better. Well, if my request looks inappropriate, feel free to reject it.

I found a related potential bug.
In dpiStmt__getQueryInfoFromParam, DPI_OCI_HTYPE_DESCRIBE is used as the handle type of the param value. Though it works, it should be DPI_OCI_DTYPE_PARAM because the param is got from OCIParamGet.

from odpi.

anthony-tuininga avatar anthony-tuininga commented on September 1, 2024

When I wrote the dpiDataTypeInfo, I didn't realize that nullOK is unavailable for object attributes and collection elements. Sorry to bother you, but could you remove the nullOk member from the dpiDataTypeInfo and put it back to dpiQueryInfo? I think that it is better.

Agreed. I looked at the documentation and it is explicitly forbidden on object attributes and collection elements -- so I have moved it back as suggested. Thanks.

I found a related potential bug. In dpiStmt__getQueryInfoFromParam, DPI_OCI_HTYPE_DESCRIBE is used as the handle type of the param value. Though it works, it should be DPI_OCI_DTYPE_PARAM because the param is got from OCIParamGet.

It does indeed work so I'll ask about what the correct code ought to be when I ask about the precision attributes, too. Thanks for your feedback.

from odpi.

kubo avatar kubo commented on September 1, 2024

Thank you!
What I want was added.

from odpi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.