Code Monkey home page Code Monkey logo

Comments (7)

mauriceackel avatar mauriceackel commented on May 22, 2024 1

I am working on this over at Maurice22/quarantine-hero@8c87da33746d67563e31d7301e4606f0f6bb3d1e

from quarantine-hero.

mauriceackel avatar mauriceackel commented on May 22, 2024 1

Ah yeah and of course I added pagination there :D Check the commit messages for more info.

from quarantine-hero.

mauriceackel avatar mauriceackel commented on May 22, 2024

So there is an issue: If we use pagination, client-side filtering of locations does not work anymore (as we won't search the whole database). I wanted to fix this by filtering the location on the database as well but it turns out that more or less firebase only allows for one filter.

Because of that I would suggest to disable pagination if a user searches for a location. What do you think? Do you have other ideas?

from quarantine-hero.

kenodressel avatar kenodressel commented on May 22, 2024

@Maurice22 Yes thats a problem but it also means we significantly reduce reads.
Our plan for today is to re-enable the google maps integration and therefore also re-enable a proper search. So I think its fine if you build it and we merge it after we re-enable the maps api.

from quarantine-hero.

mauriceackel avatar mauriceackel commented on May 22, 2024

@kenodressel Please check out my version at Maurice22/quarantine-hero@383f2c7246739be42cff0dc542c75cfca004a6ba . I completely redesigned the way queries are done, including support when maps API is enabled. Can you give it a test? If everything works fine, I will create a PR for it.

from quarantine-hero.

kenodressel avatar kenodressel commented on May 22, 2024

I took a look and it seems fine to me. You can post a PR. Are you available for a call (send mail to [email protected]) so we can include you better in our planning?

from quarantine-hero.

mauriceackel avatar mauriceackel commented on May 22, 2024

Closed in #46

from quarantine-hero.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.