Bug: uri-reference in root `$id` results in incorrect reference resolution about json-schema-validator HOT 6 CLOSED

Hi, @jrhok.

This is actually really interesting question. It seems like the library indeed have a problem when the root $id is not an absolute uri. I tried to load your schemes and the uri for foo.json was resolved as /myproject/enums/myproject/enums/foo that is definitely incorrect. I will create an issue to resolve this. I will try to fix it as soon as I can. Thank you for bringing this to my attention!

In the mean time, I could suggest use something like this instead (until I fix this)

{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://myproject/enums/foo",
  "type": "integer",
  "enum": [
    0,
    1,
    2
  ]
}

{
    "$schema": "https://json-schema.org/draft/2020-12/schema",
    "$id": "https://myproject/data/request",
    "type": "object",
    "properties": {
        "foo": {
            "type": "array",
            "items": {
                "$ref": "/enums/foo"
            }
        },
        "foobar": {
            "$ref": "/enums/foo"
        }
    }
}

from json-schema-validator.

Thank you for your quick feedbacks !
We came up with the same workaround, thanks !

from json-schema-validator.

Hi, @jrhok. I will merge the fix today - I hope you can use the snapshot version until the release is published.

Small note about the references:

In your example:

{
    "$schema": "https://json-schema.org/draft/2020-12/schema",
    "$id": "myproject/data/request",
    "type": "object",
    "properties": {
        "foo": {
            "type": "array",
            "items": {
                "$ref": "enums/foo"
            }
        },
        "foobar": {
            "$ref": "/myproject/enums/foo"
        }
    }
}

you tried to use the relative reference enums/foo. You want it to be resolved into myproject/enums/foo however, this will not happen. This will be resolved into myproject/data/enums/foo.

This happens because when you use the reference that does not start with / the resolution logic is the following:

1. Find the closest $id to the place where you use the reference;
2. Drop the last part segment;
3. Append the value from $ref to the URI we have on step 2.

So, the only option here would be to use the absolute reference in the main JSON schema.

from json-schema-validator.

Fixed in release 0.0.11

from json-schema-validator.

I have merged changes. Once snapshot (and later release) is published I will leave a comment here. Kindly, reopen the issue if you still have the same problem after updating to the newer version

from json-schema-validator.

Snapshot has been published

from json-schema-validator.