Code Monkey home page Code Monkey logo

Comments (3)

fabiankessler avatar fabiankessler commented on August 16, 2024

Regarding readAllBuiltIn():
Thanks, I've updated the README.

About Optional:
The LanguageDetector interface uses the Optional from Guava:
import com.google.common.base.Optional;
Your code probably uses the one from Java8 java.util.Optional. Can you confirm?

from language-detector.

KonradHoeffner avatar KonradHoeffner commented on August 16, 2024

Ah you are right, I could resolve the issue by changing the import to Guava Optional. But maybe refactoring to java.util.Optional would be better? As far as I see it, Guava Optional was only a stopgap measure when Java didn't support it so it is obsolete now.

from language-detector.

fabiankessler avatar fabiankessler commented on August 16, 2024

In my opinion it's way too early to require Java8.
The library language-detector currently requires Java7 and I vote for keeping it this way for quite some time.
Other libraries still support 6 or 5 to be widely usable.
My employer still runs many machines with JDK7.
As far as I can tell, the latest Ubuntu LTS (14.04) has OpenJDK7 as the default.
Concluding: at some point in the future a change could be considered. Until then I'll close this task.
Thanks for you input!

from language-detector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.