Code Monkey home page Code Monkey logo

Comments (13)

AdSchellevis avatar AdSchellevis commented on June 2, 2024

probably better ask them what they need to display an issuer... you can find their GitHub repo's at https://github.com/freeotp

from core.

Gaitonde007 avatar Gaitonde007 commented on June 2, 2024

probably better ask them what they need to display an issuer... you can find their GitHub repo's at https://github.com/freeotp

Hi, sure will do.
FYI: with pfSense it displays as FreeRadius Server since external authentication is built into that package.

Thanks.

from core.

AdSchellevis avatar AdSchellevis commented on June 2, 2024

if they add OPNsense, I don't mind adding an issuer on our end:

https://github.com/pfsense/FreeBSD-ports/blob/9fdee68a7df90cab70451ac684e2a8b21d824b08/net/pfSense-pkg-freeradius3/files/usr/local/pkg/freeradius.xml#L330

$otp_url .= $pconfig['usernamefld']."@".htmlspecialchars($config['system']['hostname'])."?secret=";

from core.

joggee-fr avatar joggee-fr commented on June 2, 2024

Hi @AdSchellevis,
I get here following freeotp/freeotp-android#387 and analyze URI returned by OPNsense in this comment freeotp/freeotp-android#387 (comment).
Just to know, did you except $config['system']['hostname'] to be viewed as the issuer here?

from core.

AdSchellevis avatar AdSchellevis commented on June 2, 2024

@joggee-fr yes, usually it shows user@domain in these type of apps.

from core.

joggee-fr avatar joggee-fr commented on June 2, 2024

@AdSchellevis
As I understand the docs on OTP URI format, in the case otpauth://totp/User1@Mail_VPN?secret=, User1@Mail_VPN is the account name. FreeOTP seems to choose to display the issuer but none is precised here.
OPNsense:User1@Mail_VPN would certainly display OPNsense as issuer for example. Or it seems it can also be added as URI parameters OPNsense:User1@Mail_VPN?secret=&issuer=OPNsense.

from core.

AdSchellevis avatar AdSchellevis commented on June 2, 2024

I don't mind adding an issuer, but I don't expect them to have a logo on their end....

from core.

joggee-fr avatar joggee-fr commented on June 2, 2024

If I am right, FreeOTP will display a custom logo if:

  1. A logo for the issuer has been defined in the app (hard-coded stuff). If you had the issuer, someone may propose a PR to add an associated image in FreeOTP ;
  2. Or you had image to the URI parameters e.g. discussed here.

from core.

AdSchellevis avatar AdSchellevis commented on June 2, 2024

@joggee-fr can you try 12001a3 ? install via:

opnsense-patch 12001a3

from core.

joggee-fr avatar joggee-fr commented on June 2, 2024

@Gaitonde007, as you are the initial reporter could you give this patch a test?

from core.

Gaitonde007 avatar Gaitonde007 commented on June 2, 2024

@Gaitonde007, as you are the initial reporter could you give this patch a test?

Hi @joggee-fr , I have tested on Android and it works as expected. Issue on IOS still persists.

Thanks

from core.

joggee-fr avatar joggee-fr commented on June 2, 2024

@Gaitonde007, I am not aware of the iOS version of the FreeOTP application. However, did you open an issue there?

from core.

Gaitonde007 avatar Gaitonde007 commented on June 2, 2024

@Gaitonde007, I am not aware of the iOS version of the FreeOTP application. However, did you open an issue there?

Sorry for my ignorance, I will report it there. I believe they have to do something similar which was done with Android?

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.