getTraceIdsByAnnotation about zipkin HOT 4 CLOSED

I'm unsure about the first one and will take a closer look tomorrow.
For the second one, core annotations are the four annotations that we expect to see in every span:

• client send (cs)
• server receive (sr)
• server send (ss)
• client receive (cr)

These fully describe a method call. We don't index these since we expect all spans to contain them, and you already get that kind of functionality from searching by span name or service name. We only really want to index custom annotations that users provide in their application code.

from zipkin.

I guess there's nothing theoretically wrong with a core annotation existing in the annotations index; it's mainly just a performance optimization to avoid unnecessary writes.

from zipkin.

hmm, neat.

from zipkin.

First point is fixed in #93, going to go ahead and close this issue

from zipkin.