Add support for Observables about brave-ratpack HOT 10 CLOSED

Started a release of 2.4.0.

Part of the reason for making some of these things private is to avoid breaking things if we decided to change internal pieces. Also it forces us to look at the reason the work around is necessary and try to solve it in a way that doesn't require work arounds. Fortunately in this case Ratpack 1.6 added what we always needed and @beckje01 was quick to address this.

@garadox do you feel that the ExecInitializer will solve problems you have with Ratpack Observables?

from brave-ratpack.

I understand not wanting to have to rely on reflection for things, in lieu of help from a Ratpack expert there are a couple things I can see that might work. There is a deprecated method on RatpackCurrentTraceContext that you could use instead of having to rely on reflection: RatpackCurrentTraceContext.wrap(TraceContext)

I'm also seeing maybe wrapping your Execution.current() with: TracingPropagationExecInitializer.init(Execution) would do what you are looking for.

from brave-ratpack.

Is TracingPropagationExecInitializer a new class? I'm not finding that class in this repo or in the main brave repo.

from brave-ratpack.

Sorry, its an sub-class (internal?) in RatpackCurrentTraceContext

from brave-ratpack.

Hmm, i'm not seeing that class in version 2.3.2 .

from brave-ratpack.

It was added Jan 4th, but 2.3.2 was released Jan 2nd.

from brave-ratpack.

@hyleung @llinder @adriancole @beckje01 Can you make a new release of the Current master branch code with TracingPropagationExecInitializer.init(Execution) ASAP. Since Our application in production is using Ratpack and Kotlin and are facing issues as TraceContext is not propagated properly and doesn't have any public functions to manually update TraceContext in TraceContextHolder .

from brave-ratpack.

Release of 2.4.0 is done. Just waiting on Maven Central to update with the synced artifacts.

from brave-ratpack.

@llinder Yes, I believe the ExecInitializer will address my current workaround (It's use of execution.maybeParent and being non-private is the key).

from brave-ratpack.

Ah, I just realized the Ratpack 1.6 dependency. We can't test this yet but i'll close the issue and come back once we've upgraded if there are still issues.

from brave-ratpack.