Code Monkey home page Code Monkey logo

Comments (28)

saturnism avatar saturnism commented on July 20, 2024

/cc @adriancole

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

will take a look tomorrow first thing. missed it!

from docker-zipkin-gcp.

saturnism avatar saturnism commented on July 20, 2024

Thanks! I was having trouble tracing back the container used. Is it using Alpine by any chance? If so.. that could explain the issue.

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

pushing image zipkin-gcp 0.7.0 now

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

if you don't mind, can you q/a for me once it is on dockerhub? I am watching now, so if there's a problem i will see and dig

from docker-zipkin-gcp.

saturnism avatar saturnism commented on July 20, 2024

i just gave 0.7.0 tag a try, but seeing the same issue. I think the base image is still alpine.

I haven't been able to trace the root base image:

FROM openzipkin/zipkin:2.11.1
...
RUN apk add unzip <- this still looks like alpine based distribution
...

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

the base images is this https://github.com/openzipkin/docker-jre-full

I will try to run and see

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

It is failing on OpenSsl required. Our base image for very long time has been alpine. Perhaps there's a package missing or something new in a later version of grpc that wasn't the case earlier

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

I'm very much hoping that netty/netty-tcnative#111 isn't true and grpc isn't unsupported on alpine :P

@saturnism say it ain't so!

cc @openzipkin/devops-tooling

from docker-zipkin-gcp.

saturnism avatar saturnism commented on July 20, 2024

afaik, it never supported alpine's libmusl :(
https://github.com/grpc/grpc-java/blob/master/SECURITY.md#troubleshooting <- I wrote most of this ;)

For smaller images, I'd recommend openjdk:8-jre-slim, or gcr.io/distroless/java :(

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

from docker-zipkin-gcp.

saturnism avatar saturnism commented on July 20, 2024

Makes sense!

The other option is to add glibc to this image. but i don't think there is official support.

In the past we had a stackdriver zipkin proxy image that was hosted on gcr.io. That one worked for sure.

Thanks for taking a look!

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

one of the things I believe google should be doing while promoting gcp is doing more to help norman. For example, this PR could have gotten alpine.. when there's a surge of demand on projects like netty, it could be good to dig in and help netty/netty-tcnative#252

if that happened, we'd probably have no dillemma right now, but there's still a chance to change the future :) @saturnism can you take this feedback to google? :P

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

opened openzipkin/docker-java#9 to track us moving our base image to JRE 11, which will obviate the ssl concern

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

I am testing images.. so far zipkin-gcp up to 0.6.0 works. I think something changed where possibly falling back when openssl isn't available changed to crash the server

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

zipkin-gcp 0.6.2 works, it started crashing in 0.6.3

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

so this happened when we upgraded from grpc 1.11.0 to 1.13.1. One way out is to revert that.. this is the easiest. then we just upgrade later

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

screen shot 2018-08-09 at 1 33 00 pm

so this is from the 0.6.2 image

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

checking to see if this is related to us changing to a different alpine image, which is entirely possible

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

ok we are getting somewhere.. our base zipkin image switch from zulu to openjdk jre (both alpine) starting with zipkin 2.9.4.

Must be that the zulu image had openssl else the error would have occurred much earlier
https://github.com/openzipkin/zipkin-gcp/blob/master/autoconfigure/storage-stackdriver/src/main/java/zipkin/autoconfigure/storage/stackdriver/ZipkinStackdriverStorageAutoConfiguration.java#L83

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

so the original image depended on, so this is why it worked https://hub.docker.com/r/frolvlad/alpine-glibc/~/dockerfile/

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

Spoke with @anuraaga. We are going to save ourselves some time by using ALPN bootstrap for now. Later, we can just update to JDK 11. openzipkin/zipkin-gcp#91

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

tested with a local docker build and works

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

ok 0.7.1 should fix this. thanks especially @anuraaga for helping find a way out of this problem without implying lot of temporary image reshuffling.

from docker-zipkin-gcp.

codefromthecrypt avatar codefromthecrypt commented on July 20, 2024

tested published image, so hopefully also works for others!

from docker-zipkin-gcp.

saturnism avatar saturnism commented on July 20, 2024

Yay! That started off fine. Thank you!

from docker-zipkin-gcp.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.