Install step copy feature on documentation is possibly incorrect about docs.openzeppelin.com HOT 5 CLOSED

Thanks for the review @frangio I updated the PR #297 and opened a second one for the babelXRollup #298

from docs.openzeppelin.com.

Thanks for the issue. Please open a PR.

The fix should go in 07-copy-code.js.

If we detect that the code being copied is shell commands, we should remove any leading $ . We should try to only do this if the code was configured as a shell/console block by inspecting the class of the code element.

from docs.openzeppelin.com.

Thanks for the insight @frangio. I have working code on my local but was wondering if I can get your opinion on an aspect of the solution.

First, I noticed that the wrapping code has a class of language-sh and a data-lang="sh". In my solution, I'm referencing the data attribute and not the class as it's generally more reliable and prefered over classes. Does that sound acceptable in your opinion?

Second, I noticed that for shell commands we are using language-sh and a data-lang="sh" but in the highlight.js docs they support multiple shell related syntax and aliases. source: https://github.com/highlightjs/highlight.js/blob/main/SUPPORTED_LANGUAGES.md

Should I account for all possible shell languages and aliases (future proof) or just the currently used language-sh/ data-lang="sh"?

Thanks again!

from docs.openzeppelin.com.

Using data-lang is fine.

Let's try to support all aliases, because we're not being consistent across the docs and we use different kinds of language names. The following should suffice: console, shell, sh, bash.

from docs.openzeppelin.com.

Thanks @frangio, I opened the pull request.

from docs.openzeppelin.com.