custom CFLAGS lead to missing -c [was: -flto -fwhole-program does not work] about john HOT 7 CLOSED

seems the primary bug is that "-c" gets removed from the CFLAGS when the user passes his own set...

from john.

We have a JOHN_CFLAGS that you can use to add stuff without dropping our usual CFLAGS.

from john.

yes, however this is unexpected behaviour.
the polite way would be to just accept the user-passed cflags without breaking
kinda like:

STANDARD_CFLAGS= -c -fomit-frame-pointer ...
ALL_CFLAGS = $(STANDARD_CFLAGS) $(CFLAGS) $(JOHN_CFLAGS)
...
target-xxx:
          $(CC) $(ALL_CFLAGS) $@

edit: reversed cflags order so that user supplied flags come last to override opt levels

from john.

I'm fine with that but we need to discuss it on john-dev because I have no idea about the history of the current behaviour. Actually some comments in params.h (iirc) claim that you can use CFLAGS normally (add to it).

from john.

the most proper way to handle this specific case though is when $(CC) is always followed by -c in the makefile target.
i.e. not in the CFLAGS

target-xxx:
        $(CC) -c $@ $(CFLAGS)

from john.

Agreed. We should do that to the bleeding branch. But ideally Solar should do it in core first (or too).

from john.

This was fixed once we started using AC.

from john.