master branch does not compile on kernel 6.2-rc4 about ovpn-dco HOT 18 CLOSED

Hi! This is work in progress and will update the code ASAP

from ovpn-dco.

if you have already some patches I am available to test it

from ovpn-dco.

news ?

from ovpn-dco.

Don't be pushy. It is ready when it is ready.

from ovpn-dco.

gcc --version
gcc (Debian 12.2.0-14) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

root@ghost:/usr/src/ovpn-dco# cc --version
cc (Debian 12.2.0-14) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

from ovpn-dco.

make
/usr/src/ovpn-dco/gen-compat-autoconf.sh /usr/src/ovpn-dco/compat-autoconf.h
make -C /lib/modules/6.2.0-rc4/build M=/usr/src/ovpn-dco PWD=/usr/src/ovpn-dco REVISION=0.1.20221107-3-g2fbc4e8 CONFIG_OVPN_DCO=m INSTALL_MOD_DIR=updates/ modules
make[1]: Entering directory '/usr/src/linux-headers-6.2.0-rc4'
CC [M] /usr/src/ovpn-dco/drivers/net/ovpn-dco/main.o
CC [M] /usr/src/ovpn-dco/drivers/net/ovpn-dco/bind.o
CC [M] /usr/src/ovpn-dco/drivers/net/ovpn-dco/crypto.o
CC [M] /usr/src/ovpn-dco/drivers/net/ovpn-dco/ovpn.o
CC [M] /usr/src/ovpn-dco/drivers/net/ovpn-dco/peer.o
CC [M] /usr/src/ovpn-dco/drivers/net/ovpn-dco/sock.o
CC [M] /usr/src/ovpn-dco/drivers/net/ovpn-dco/stats.o
CC [M] /usr/src/ovpn-dco/drivers/net/ovpn-dco/netlink.o
/usr/src/ovpn-dco/drivers/net/ovpn-dco/netlink.c:950:21: error: initialization of 'int (*)(const struct genl_split_ops *, struct sk_buff *, struct genl_info )' from incompatible pointer type 'int ()(const struct genl_ops *, struct sk_buff *, struct genl_info )' [-Werror=incompatible-pointer-types]
950 | .pre_doit = ovpn_pre_doit,
| ^~~~~~~~~~~~~
/usr/src/ovpn-dco/drivers/net/ovpn-dco/netlink.c:950:21: note: (near initialization for 'ovpn_netlink_family.pre_doit')
/usr/src/ovpn-dco/drivers/net/ovpn-dco/netlink.c:951:22: error: initialization of 'void ()(const struct genl_split_ops *, struct sk_buff *, struct genl_info )' from incompatible pointer type 'void ()(const struct genl_ops *, struct sk_buff *, struct genl_info *)' [-Werror=incompatible-pointer-types]
951 | .post_doit = ovpn_post_doit,
| ^~~~~~~~~~~~~~
/usr/src/ovpn-dco/drivers/net/ovpn-dco/netlink.c:951:22: note: (near initialization for 'ovpn_netlink_family.post_doit')
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:252: /usr/src/ovpn-dco/drivers/net/ovpn-dco/netlink.o] Error 1
make[2]: *** [scripts/Makefile.build:504: /usr/src/ovpn-dco/drivers/net/ovpn-dco] Error 2
make[1]: *** [Makefile:2008: /usr/src/ovpn-dco] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-6.2.0-rc4'
make: *** [Makefile:52: all] Error 2
root@ghost:/usr/src/ovpn-dco# uname -a
Linux ghost 6.2.0-rc4 #2 SMP PREEMPT_DYNAMIC Tue Jan 17 13:35:46 CET 2023 x86_64 GNU/Linux

from ovpn-dco.

I think you forgot to add some message?
The compiler output is pretty clear already, no need to post it again :)

The netlink ops struct has been redesigned and it requires ovpn-dco to adapt to the new definition.
Unfortunately right now there are a couple of bugs on my plate which require higher attention.

Port to latest kernel will happen right after!

Thanks for bearing with me

from ovpn-dco.

sorry ....

I tried to patch it myself with my hello.c knowledge but obviously apart from the risk of exploding or starting ww3 I haven't got much ;)

from ovpn-dco.

glad none of the two events happened :-D
Anyway, I should be able to get it done soonish.

from ovpn-dco.

@xevilstar could you give a try to the genl_split_ops branch and let me know how it goes?
Thanks!

from ovpn-dco.

from ovpn-dco.

no

[Fri Jan 20 17:32:39 2023] ovpn: can't register netlink family
[Fri Jan 20 17:32:39 2023] ovpn: initialization failed, error status=-22

from ovpn-dco.

cannot modprobe cannot insmod

from ovpn-dco.

Thanks for testing. This is an issue that started with 6.1. Will fix this soon too 😅

from ovpn-dco.

Let's open a specific issue for that, please

from ovpn-dco.

compilation is now fixed. However, we need to come up with some non-trivial compat code that allows the new code to still compile on older kernels.

from ovpn-dco.

Thanks, now ... there should be a way to make this new source get into debian dkms package ..... ;)

from ovpn-dco.

Yeah, hopefully they will pull the next tag (which I plan to stamp at the end of the month)

from ovpn-dco.