fvar.instances returns empty name entry if nameID is 17 (preferredSubfamily) about opentype.js HOT 13 CLOSED

as of Glyphs 1.3.2

@owenhoskins Are you sure about this? Do you mean Glyphs 3.2 or Glyphs 1.3.2? Can you post the exact build number in the bottom left at Glyphs > About Glyphs? It's the one in parantheses.

from opentype.js.

@Connum Ill see if I can get a google summer of code sponsorship or something to work on opentype.js, The main thing holding me back is the bad job I currently have, a sponsorship would enable me to work on this dedicated.

from opentype.js.

We're having this exact problem as of Glyphs 3.1.2, thanks for posting the issue @eweracs

from opentype.js.

Typo thanks @eweracs - Glyphs 3.1.2 (3151) and Glyphs 3.2 (3245)

from opentype.js.

After a very quick lock, I think it could be related to this comment in the code

So the issue was introduced with a specific update of our library in your software? Can you tell us the specific commits that were used in the version that introduced the issue and the one before?

from opentype.js.

Hello @Connum, thanks for looking into this. That does indeed look like the issue.

The issue was not necessarily introduced with a specific version of the Glyphs font editor, it just so happens that Glyphs doesn't add a separate name table entry for the default instance but simply references ID 17 (preferredSubfamily), since the default instance and preferredSubfamily are supposed to be identical as per the variable font spec.

In Kürze: It looks like opentype.js searches for the key preferredSubfamily (but I may be wrong in my quick read of the code). It should, instead, search for the key 17. So the fvar table needs to be handled before name, just as your comment suggests.

A fix for this would be most appreciated, I have a project depending on this which means it currently necessitates quite an extensive workaround. Thanks!

from opentype.js.

Alright, I will look into this once I finish my current WIP with COLR/CPAL rendering, hopefully tonight or tomorrow.

BTW, would Glyphs be interested in sponsoring (and therefore speeding up) opentype.js development? (see #622)

from opentype.js.

Thanks a lot! I can't speak on Glyphs' behalf, I'm not associated with Glyphs. In terms of sponsoring, a sponsoring from Google's side would surely make sense. But I'm veering off-topic.

from opentype.js.

I'm taking a look at this right now. @eweracs Could you provide a very basic test font (needs nothing that doesn't help reproduce this issue) that we can include for our test cases?

from opentype.js.

Many thanks. I'm not at my computer right now, but I will prepare one in a bit.

from opentype.js.

Here is one:

VARTest.ttf.zip

You will find that the fvar table is reported to contain an unnamed instance, the default instance (with nameID 17).

from opentype.js.

Will be fixed via #694.

from opentype.js.

Brilliant! Thank you!

from opentype.js.