Frame-per-second counter / texteff.c clean-up about openttd HOT 10 CLOSED

matthijs wrote:

Can somebody check this on Windows and MacOS, since I don't have access to that.
Looks like a well written (and documented :-D) patch. It will probably be committed after our next release, since we will only perform the most critical fixes before the release.

This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment64

from openttd.

egladil wrote:

It seems to be working on OS X. It gave some warnings about missing function declarations, so I made cocoa_v.m include textmessagebox.h which solved the problem.

Attachments

• fps2.diff (15.90 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment65

from openttd.

webfreakz.nl wrote:

It doesn't compile on WinXP Pro + MSVC6, see the atteched compile-log.

Attachments

• Output - Build3.txt (6.63 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment77

from openttd.

oteek wrote:

fps3.diff
---------
against r3396
included textmessagebox.h in cocoa_v.m (thanks egladil)
included textmessagebox.h in win32_v.c
added few CDECLs to textmessagebox.c
updated openttd.vcproj
updated openttd.dsp
fixed typo

please test it ronald, i hope that it compiles now.

Attachments

• fps3.diff (40.91 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment78

from openttd.

webfreakz.nl wrote:

Still doesn't compile.

Attachments

• Output - Build4.txt (7.67 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment79

from openttd.

oteek wrote:

this looks weird:
C:$gamesbllaattextmessagebox.c(1122) : error C2084: function 'void __fastcall __fastcall ChatDailyLoop(void )' already has a body
textmessagebox.c has only 608 lines, so you might have applied patch twice (or not reverted fps2.diff), try using clean svn version + fps3.diff, textmessagebox.c can't be that long.

This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment80

from openttd.

webfreakz.nl wrote:

Well I did you what you said above but I thought it would not work as I reverted the patch fps(2).diff and did for both a compile, but didn't work (it showed though as green marker on the directory name which means it's a clean SVN source). But after deleting the whole directory and a new SVN-checkout + applying the patch it said:

openttd.exe - 0 error(s), 1 warning(s)

This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment81

from openttd.

oteek wrote:

i believe that the warning was only this (from Build4.txt):
langswedish.txt:2703: Warning: STR_REPLACE_VEHICLES_WHITE: Param idx # 0 '' doesn't match with template command 'STRING'
which has nothing to do with this patch, so it compiles after all :)
i hope that it works too. (one part (fps counter - really useful only with fast forward) is enabled by _DEBUG and has to be enabled by 'display_info 1' in console, second (network chat) is enabled always)

This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment82

from openttd.

TrueBrain wrote:

Can someone clean up this patch and give a patch that ONLY does the fps? (so without the moving and stuff)

This comment was imported from FlySpray: https://bugs.openttd.org/task/34#comment1440

from openttd.

Rubidium closed the ticket.

Reason for closing: Duplicate

Of #1065.

This comment was imported from FlySpray: https://bugs.openttd.org/task/34

from openttd.