opentransportro / transitime Goto Github PK

Hi,

There is list of endpoints what we current use in our web-app:

1. command

/command/allCalendars
/command/addAVLExport
/command/activeBlockByRouteNameWithVehicles
/command/activeBlocksByRouteWithoutVehicles
/command/blocks
/command/blockIds
/command/blocksTerse
/command/currentCalendars
/command/exports
/command/getExportFile
/command/gtfs-rt/tripUpdates
/command/routesDetails
/command/routes
/command/removeVehicleToBlock
/command/vehicleToBlock
/command/vehiclesToBlock
/command/vehicleIds
/command/vehiclesDetails
/command/cancelTrip
/command/reenableTrip
/command/scheduleVertStops
/command/serviceIds
/command/trip
/command/tripIds
/command/siri/vehicleMonitoring
/command/stops

2. reports

/reports/avlReport
/reports/lastAvlJsonData
/reports/scheduleAdh
/reports/tripsWithTravelTimes
/reports/tripsByDate
-> .jsp
/reports/predAccuracyIntervalsData.jsp
/reports/predAccuracyRangeData.jsp
/reports/data/summaryScheduleAdherence.jsp
/reports/predAccuracyScatterData.jsp

Regards,
goEuropa

Is your enhancement request to replace an existing functionality within TheTransitClock?
If the functionality already exists, please provide a clear description of its current behavior.

Is your enhancement request related to a problem? Please describe.
A clear description of what the problem is.

Describe the solution you'd like
A clear description of the expected functionality.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Example datasets
Please provide related datasets to test and validate the new functionality.

Hi,
best is the compare between your TC and our TC:

this doesn't give any data back - scheduleAdh
https://transitclock.xxx.xxx/api/v1/key/f78a2e9a/agency/26/reports/scheduleAdh?r=401&beginDate=02-14-2024&numDays=1&beginTime=00%3A01&endTime=23%3A59&allowableEarly=1&allowableLate=3

ours does:
https://xxx.net:8099/api/v1/key/f78a2e9a/agency/26/reports/scheduleAdh?r=401&beginDate=02-14-2024&numDays=1&beginTime=00%3A01&endTime=23%3A59&allowableEarly=1&allowableLate=3

and another one is avlReport
has no data: https://transitclock.xxx.xxx/api/v1/key/f78a2e9a/agency/26/reports/avlReport?v=4203&beginDate=02-14-2024&numDays=1&beginTime=12%3A55&endTime=13%3A20
has data: https://xxx.net:8099/api/v1/key/f78a2e9a/agency/26/reports/avlReport?v=4203&beginDate=02-14-2024&numDays=1&beginTime=12%3A55&endTime=13%3A20
For the avlReport , i noticed that dropdown with vehicles is empty in AVL reports in the web interface of your TC.

1. Block id is not required, but mostly the following endpoint won't return anything, if you don't provide block id as parameter (this vehiclesToBlock is populated by post command of vehicletoblock)

/command/vehiclesToBlock?blockId=412-1-2

Suggestion to have this endpoint work without any parameters and return info for all block ids

2. Too many requests required for this endpoint of schedule adherence by route endpoint:

reports/scheduleAdh?r=494&beginDate=03-21-2024&numDays=1&beginTime=00%3A01&endTime=23%3A59&allowableEarly=1&allowableLate=3

For each trip, it should contain also vehicle id, as otherwise we need to send requests to many endpoints like the one below:
/reports/tripWithTravelTimes?tripId=494-1-2-R-16%3A31&date=2024-03-21

Report tripsWithTravelTimes in it's response has now 'scheduled_time' value, while before it had 'scheduledtime'.
Can this be consistent - i.e. without '_' as all others ?

Is your enhancement request to replace an existing functionality within TheTransitClock?
If the functionality already exists, please provide a clear description of its current behavior.

Is your enhancement request related to a problem? Please describe.
A clear description of what the problem is.

Describe the solution you'd like
A clear description of the expected functionality.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Example datasets
Please provide related datasets to test and validate the new functionality.

Original TC has /api as suffix to all api endpoints. This implementation doesn't use that. Same with /web suffix. Is it possible to configure TC in a way so that those prefixes are included (at least api part)?

Is your enhancement request to replace an existing functionality within TheTransitClock?
Currently migration is done through hibernate which is not quite stable and not quite so configurable. It would be very good to have migrations running using flyway or liquibase

Is your enhancement request related to a problem? Please describe.
Each time the app starts it needs a clean database because of possible conflicting migrations. This could work and works actually but if we want to ensure kalman predictions to be running , then the app should run without stop for longer period -> having the database migration in case of hotfix possible.

Describe the solution you'd like
Integrate migration management system (flyway or liquibase)

Currently there are multiple formats in which the date is expected to be formatted. There should be a unitary approach to store them and avoid having this incosistencies