Comments (15)
After four years it seems the answer to this question might be 'no'.
We'll have to take another look at this and error handling in general.
from opentoonz.
How do you think about to improve static source code analysis also for this software?
from opentoonz.
@elfring Good to hear from you.
We'd have to look at the candidates and how it might fit into the current ecosystem.
To this point most of the analysis has been at the individual level and the outlook for code analysis tools that costs anything is not good.
I must assume you have some suggestions and preferences.
from opentoonz.
There are also some free software analysis tools available.
I suggest to avoid ignorance of return values a bit more.
Would you like to detect every error situation as early as possible?
from opentoonz.
Would you like to detect every error situation as early as possible?
We are several years behind the power curve so the term 'early' is a bit relative.
Perhaps we can survey what is possible for new code that is being written as opposed to current and legacy code.
In other words to chart a path forward into 2021 and beyond.
from opentoonz.
Concerning legacy code there is one (WIP) PR currently in the cue addressing basic cppcheck suggestions:
REF: #3647
from opentoonz.
Closing as I believe this has been addressed.
@elfring please let us know if that is not the case.
from opentoonz.
I find the implementation of the class โTMutexImpโ (for example) still questionable. ๐ค
๐ฎ Is source code analysis evolving accordingly?
from opentoonz.
Thanks for the follow up.
It's great to see you back in the Opentoonz arena again.
๐ฎ Is source code analysis evolving accordingly?
I'll guess no, although we have had some success in that in the not too distant past.
It's hard to say if one of those efforts might have resolved this particular error handling concern.
One PR in particular was set to blast through most of the ancient coding but it needed to be run after rather than just prior to release given the number of changes it was targeting. (Not ideal to troubleshoot right before a release).
Sadly, the author of that PR didn't return to that task after the release.
Added REF: #3647
Given we are half way to the release of v1.7, now would be a good time to solidify plans and get some of the most questionable code updated.
from opentoonz.
๐ญ How do you think about to reopen this issue because of remaining development concerns?
from opentoonz.
I don't wish to take too much of your time but it would be educational to know more about your specific concerns.
Would you be willing to submit a PR to address and correct those specific concerns?
(or to recommend someone willing to submit those changes)
from opentoonz.
โฆ but it would be educational to know more about your specific concerns.
๐ญ I recommend to take another look at linked information sources.
The proper handling of cross-cutting concerns is a general development challenge.
(or to recommend someone willing to submit those changes)
Not yet.
I suggest to take corresponding development tools better into account. ๐ค
from opentoonz.
I should probably add...
New code submitted goes through the various tests (github actions and appveyor) and that takes care of the vast majority of code smells so in this way you could say Opentoonz code has definitely been evolving.
The older (and largely legacy) code still needs attention and that would appear to be the focus of our discussion here.
Much of that code is still present because those areas of the program haven't been updated themselves with new/improved features and optimizations. This is perhaps the optimal road forward; to actually consider what the code is doing with respect to users and to update as appropriate.
To achieve this what we need even beyond code analysis is a clear path forward for the features of Opentoonz as a whole and the optimizations that go with user interactivity and workflow. As these paths get updated the automated tools in place then do their appropriate work.
from opentoonz.
โฆ the automated tools in place then do their appropriate work.
๐ญ Such tools (and available development resources) are also evolving according to various factors.
from opentoonz.
Reopening based on your continued interest @elfring which is much appreciated.
from opentoonz.
Related Issues (20)
- Will you release 1.8 today? HOT 2
- Logitech webcam conflict / crash on startup
- OpenToonz Immediately Crashes upon brand-new fresh install HOT 1
- 132 HOT 1
- Ongoing requirement to run current nightlies HOT 1
- 33332
- 88
- will there ever be a version 1.8 or fix to the Nightly builds?
- OpenToonz crashes after adding the following expression: "col1.angle" HOT 5
- Vector line delay HOT 2
- Problem about stage schematic. HOT 1
- Why choose C++ to delevep opentoonz? HOT 3
- opentooz HOT 1
- Crashing
- init variables
- unreachable code
- init variable
- EXCEPTION_ACCESS_VIOLATION HOT 1
- Geometry Tool Incorrect Thickness on ToonzRaster Levels HOT 2
- Virus detected HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentoonz.