Crash on OTAudioDevice protocol with the func estimatedRenderDelay() about opentok-ios-sdk-samples HOT 6 OPEN

following Yoav's question, the crash is happening cause of UInt32 to UInt16 casting,
a possible solution is :

public func estimatedRenderDelay() -> UInt16 {
let value = min(self.playoutDelay, UInt32(UInt16.max))
return UInt16(value)
}

this would avoid the crash I guess, but it might cause unexpected result,
please advice

from opentok-ios-sdk-samples.

Thanks, @YoavGro, for letting us know about this issue. We've been investigating this, actually: https://jira.vonage.com/browse/OPENTOK-48681.

We haven't had any success with reproducing the issue, though. That said, we added some resiliency to one of our sample applications. Can you please see if https://github.com/opentok/opentok-ios-sdk-samples-swift/pull/177/files helps you?

Thanks! 🙏

from opentok-ios-sdk-samples.

@goncalocostamendes, does https://github.com/opentok/opentok-ios-sdk-samples-swift/pull/177/files need to be ported to this repo as well?

Please advise. Thanks!

from opentok-ios-sdk-samples.

The final version is opentok/opentok-ios-sdk-samples-swift#178! We should debated if we port it to this sample as well, yes!

Regarding this issue raised in particular, in objc casting UInt32 to UInt16 should not raise a crash, but an overflow of the variable.

@YoavGro are you using our objc or swift samples (https://github.com/opentok/opentok-ios-sdk-samples or https://github.com/opentok/opentok-ios-sdk-samples-swift)?

from opentok-ios-sdk-samples.

@goncalocostamendes, yeah, let's port that to this as well, please. Thanks!

from opentok-ios-sdk-samples.

Tracked internally as https://jira.vonage.com/browse/OPENTOK-51225

from opentok-ios-sdk-samples.