Proguard config for signed app? about opentok-android-sdk-samples HOT 9 CLOSED

Here are the proguard rules for OpenTok:
-keep class com.opentok.{ ; }
-keepclassmembers class com.opentok.{ ; }
-dontwarn com.opentok.**
-keep class org.webrtc.* { ; }

hello, these rules are way too broad, is basically says "don't touch any of the classes from my SDK"
could you please define the rules more fine grained for us?

from opentok-android-sdk-samples.

Hi @jaytarub ,

As you observe, we have not included proguard in the samples. Having Proguard run is completely optional, but highly recommended. You can find more details in the Android doc: http://developer.android.com/guide/developing/tools/proguard.html

Best,
Marina

from opentok-android-sdk-samples.

could you guide us how to config the opentok proguard? like what's the special class need be keep in proguard.

from opentok-android-sdk-samples.

Here are the proguard rules for OpenTok:
-keep class com.opentok.{ ; }
-keepclassmembers class com.opentok.{ ; }
-dontwarn com.opentok.**
-keep class org.webrtc.* { ; }

from opentok-android-sdk-samples.

In 2.22.1 I also needed:

-keep class com.vonage.** { *; }

from opentok-android-sdk-samples.

Hi @jaytarub ,

I’m closing this issue because it has been inactive for a few weeks.

Please reopen if you still encounter this issue. You can also contribute directly to samples by providing a patch.

Thank you!

Best,
Marina

from opentok-android-sdk-samples.

There's a mistake in the above rules:
-keep class org.webrtc.** { ; }
-dontwarn com.opentok.*
-keep class com.opentok.** { *; }
-keepclassmembers class com.opentok.{ *; }

from opentok-android-sdk-samples.

This seems to be ok:

-keep class com.opentok.** { ; }
-keep class org.webrtc.* { *; }

from opentok-android-sdk-samples.

With new vonage sdks, only this configuration will work:

-keep class com.opentok.** { ; }
-keep class com.vonage.* { ; }
-keep class org.webrtc.* { ; }
-keep class org.otwebrtc.* { *; }

from opentok-android-sdk-samples.